Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-728

Add synchronization to avoid race condition of multiple imports working concurrently

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.3
    • Fix Version/s: 1.4
    • Labels:
      None

      Description

      see http://www.nabble.com/dataimporthandler-and-multiple-delta-import-td19160129.html
      DataimportHandler import command should check if status is not idle, to avoid race conditions

      1. SOLR-728.patch
        4 kB
        Shalin Shekhar Mangar
      2. SOLR-728.patch
        4 kB
        Shalin Shekhar Mangar

        Activity

        Hide
        gsingers Grant Ingersoll added a comment -

        Bulk close for Solr 1.4

        Show
        gsingers Grant Ingersoll added a comment - Bulk close for Solr 1.4
        Hide
        shalinmangar Shalin Shekhar Mangar added a comment -

        Committed revision 707295.

        Thanks Walter!

        Show
        shalinmangar Shalin Shekhar Mangar added a comment - Committed revision 707295. Thanks Walter!
        Hide
        shalinmangar Shalin Shekhar Mangar added a comment -

        The previous patch did not pass the test due to incorrect logic when dealing with first use.

        Attached patch fixes it. I'll commit this shortly.

        Show
        shalinmangar Shalin Shekhar Mangar added a comment - The previous patch did not pass the test due to incorrect logic when dealing with first use. Attached patch fixes it. I'll commit this shortly.
        Hide
        shalinmangar Shalin Shekhar Mangar added a comment -

        Patch which uses ReentrantLock in DataImporter to make sure only one import is running at a given time.

        I'll commit this in a day or two.

        Show
        shalinmangar Shalin Shekhar Mangar added a comment - Patch which uses ReentrantLock in DataImporter to make sure only one import is running at a given time. I'll commit this in a day or two.
        Hide
        shalinmangar Shalin Shekhar Mangar added a comment -

        Unmarking this for 1.3 – the changes may be too invasive. We shall fix this in the next release.

        Show
        shalinmangar Shalin Shekhar Mangar added a comment - Unmarking this for 1.3 – the changes may be too invasive. We shall fix this in the next release.
        Hide
        shalinmangar Shalin Shekhar Mangar added a comment -

        Marking this bug for 1.3

        Show
        shalinmangar Shalin Shekhar Mangar added a comment - Marking this bug for 1.3

          People

          • Assignee:
            shalinmangar Shalin Shekhar Mangar
            Reporter:
            waltersbox Walter Ferrara
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development