[SOLR-7258] Forbid MessageFormat.format and MessageFormat single-arg constructor

• Type: Task
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 5.1, 6.0
• Assignee: Shalin Shekhar Mangar
• Reporter: Shalin Shekhar Mangar
• Created: 17/Mar/15 16:40
• Updated: 09/May/16 18:56
• Resolved: 17/Mar/15 22:09

Description

While tracing some TestBlobHandler failures with the thai locale I found that the problem was MessageFormat.format which when given a Number ultimately executes NumberFormat.getInstance(getLocale()).format(argument). In thai locale, this transforms the digit 1 to a thai character and hence fails the test.

We should audit all usages of MessageFormat.format to see if any Number objects are being passed as argument and wrap them with String.valueOf().

Edit - Actually most format operations use the default locale so we should just ban this API outright.

Issue Links

• breaks: SOLR-6955 TestBlobHandler Failure.
• contains: SOLR-6955 TestBlobHandler Failure.
• duplicates: SOLR-7244 reproducible failures for TestDynamicLoading (thai locale)
• duplicates: SOLR-6917 TestDynamicLoading fails frequently.
• is related to: SOLR-7244 reproducible failures for TestDynamicLoading (thai locale)