Solr
  1. Solr
  2. SOLR-7239

StatsComponent perf improvement for min, max, and situations where all stats disabled

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.1, 6.0
    • Component/s: None
    • Labels:
      None

      Description

      as mentioned in SOLR-6349, when i started doing perf testing of requesting individual stats, i noticed that min (and it turns out max) were slower to compute then more complex stats like sum & mean.

      While investigating, i realized that we can also optimize the case where a stats.field param is specified, but no stats are computed for example: stats.field=

      {!min=$doMin}

      fieldname&doMin=false

        Issue Links

          Activity

          Hide
          Hoss Man added a comment -

          this patch optimizes away the "none" stat case, as well as caches the min/max numeric values in a double primitive (the Double object is still used for the null check in the event that no values exist at all)

          Show
          Hoss Man added a comment - this patch optimizes away the "none" stat case, as well as caches the min/max numeric values in a double primitive (the Double object is still used for the null check in the event that no values exist at all)
          Hide
          ASF subversion and git services added a comment -

          Commit 1666294 from hossman@apache.org in branch 'dev/trunk'
          [ https://svn.apache.org/r1666294 ]

          SOLR-7239: improved performance of min & max in StatsComponent, as well as situations where local params disable all stats

          Show
          ASF subversion and git services added a comment - Commit 1666294 from hossman@apache.org in branch 'dev/trunk' [ https://svn.apache.org/r1666294 ] SOLR-7239 : improved performance of min & max in StatsComponent, as well as situations where local params disable all stats
          Hide
          ASF subversion and git services added a comment -

          Commit 1666310 from hossman@apache.org in branch 'dev/branches/branch_5x'
          [ https://svn.apache.org/r1666310 ]

          SOLR-7239: improved performance of min & max in StatsComponent, as well as situations where local params disable all stats (merge r1666294)

          Show
          ASF subversion and git services added a comment - Commit 1666310 from hossman@apache.org in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1666310 ] SOLR-7239 : improved performance of min & max in StatsComponent, as well as situations where local params disable all stats (merge r1666294)
          Hide
          Timothy Potter added a comment -

          Bulk close after 5.1 release

          Show
          Timothy Potter added a comment - Bulk close after 5.1 release

            People

            • Assignee:
              Hoss Man
              Reporter:
              Hoss Man
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development