Here's a patch that explodes the server/webapps/solr.war into server/solr-webapp/webapp and then removes solr.war.
This gives us a couple of nice things:
1) Jetty no longer has to extract the solr.war, so production installs can make the distribution folder read-only, i.e. /opt/solr can be read-only with all writing happening in /var/solr
2) No more need to extract the WAR to run tools like zkCli.sh and SolrCLI (esp. problematic on Windows where you don't have JAR if you're running with a JRE instead of JDK)
3) One step closer to truly no war
4) Reduces the size of the tgz file by about 12MB
nightly-smoke passes with this patch but I'd still appreciate a review of the smoke test python code I had to change
Lastly, I'm wondering if we shouldn't delete the server/webapps directory too? I left it in there now, but I think it should go away. And while we're at it, maybe we should rename the server/solr-webapp directory to something non-webapp specific, server/solr-??? (i'm terrible at naming things but seems like a reasonable time to remove any mention of webapp)