Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.3
    • Component/s: None
    • Labels:
      None

      Description

      It's often very useful to be able to put comments in a large query string, or temporarily comment out part of a large query string.

      This feature adds C-style comments that may be nested.

      Query Comments Example:

      description:HDTV /* TODO: +promotion:tv +promotion_date:[NOW/DAY-7DAYS TO NOW/DAY+1DAY] */
      
      1. SOLR-7220.patch
        48 kB
        Yonik Seeley

        Issue Links

          Activity

          Hide
          Yonik Seeley added a comment -

          Here's the patch ported over from Heliosearch.

          Show
          Yonik Seeley added a comment - Here's the patch ported over from Heliosearch.
          Hide
          ASF subversion and git services added a comment -

          Commit 1694273 from Yonik Seeley in branch 'dev/trunk'
          [ https://svn.apache.org/r1694273 ]

          SOLR-7220: Nested C-style comments in solr queries.

          Show
          ASF subversion and git services added a comment - Commit 1694273 from Yonik Seeley in branch 'dev/trunk' [ https://svn.apache.org/r1694273 ] SOLR-7220 : Nested C-style comments in solr queries.
          Hide
          ASF subversion and git services added a comment -

          Commit 1694275 from Yonik Seeley in branch 'dev/branches/branch_5x'
          [ https://svn.apache.org/r1694275 ]

          SOLR-7220: Nested C-style comments in solr queries.

          Show
          ASF subversion and git services added a comment - Commit 1694275 from Yonik Seeley in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1694275 ] SOLR-7220 : Nested C-style comments in solr queries.
          Hide
          Shalin Shekhar Mangar added a comment -

          Bulk close for 5.3.0 release

          Show
          Shalin Shekhar Mangar added a comment - Bulk close for 5.3.0 release
          Hide
          Scott Blum added a comment -

          I believe this patch created a bug. Regular expression queries that start with an escaped forward-slash don't work anymore.

          Works: foo:/ab\/c/
          Does not work: foo:/\/abc/
          Work around, put the beginning slash in a character class: foo:/[\/]abc/
          

          I have attached a patch to fix.

          Show
          Scott Blum added a comment - I believe this patch created a bug. Regular expression queries that start with an escaped forward-slash don't work anymore. Works: foo:/ab\/c/ Does not work: foo:/\/abc/ Work around, put the beginning slash in a character class: foo:/[\/]abc/ I have attached a patch to fix.
          Hide
          Scott Blum added a comment -

          Actually I can't attach a patch

          Show
          Scott Blum added a comment - Actually I can't attach a patch
          Show
          Scott Blum added a comment - Opened https://issues.apache.org/jira/browse/SOLR-8605

            People

            • Assignee:
              Unassigned
              Reporter:
              Yonik Seeley
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development