Solr
  1. Solr
  2. SOLR-7202

Remove deprecated DELETECOLLECTION, CREATECOLLECTION, RELOADCOLLECTION Collection API actions

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.1, 6.0
    • Component/s: None
    • Labels:
      None

      Description

      I think we can remove DELETECOLLECTION, CREATECOLLECTION, RELOADCOLLECTION action types.

      It was marked as deprecated but didn't get removed in 5.0

      While doing a quick check I saw that we can remove Overseer.REMOVECOLLECTION and Overseer.REMOVESHARD

      Any reason why it should be a bad idea?

      1. SOLR-7202.patch
        12 kB
        Varun Thacker

        Activity

        Hide
        Erick Erickson added a comment -

        This is just some internal constants, right? For a minute I thought you were talking making the actions away completely!

        Show
        Erick Erickson added a comment - This is just some internal constants, right? For a minute I thought you were talking making the actions away completely!
        Hide
        Shalin Shekhar Mangar added a comment -

        +1

        Show
        Shalin Shekhar Mangar added a comment - +1
        Hide
        Varun Thacker added a comment -

        The following deprecated Collections API calls will be removed with this patch- "deletecollection", "createcollection", "reloadcollection", "removecollection", "removeshard".

        The equivalent calls that have existed for these are - "delete", "create", "reload", "delete", "deleteshard"

        Tests and precommit are happy

        Show
        Varun Thacker added a comment - The following deprecated Collections API calls will be removed with this patch- "deletecollection", "createcollection", "reloadcollection", "removecollection", "removeshard". The equivalent calls that have existed for these are - "delete", "create", "reload", "delete", "deleteshard" Tests and precommit are happy
        Hide
        Shalin Shekhar Mangar added a comment -

        +1 LGTM

        Show
        Shalin Shekhar Mangar added a comment - +1 LGTM
        Hide
        ASF subversion and git services added a comment -

        Commit 1669748 from Varun Thacker in branch 'dev/trunk'
        [ https://svn.apache.org/r1669748 ]

        SOLR-7202: Remove deprecated string action types in Overseer, OverseerCollectionProcessor - deletecollection, createcollection, reloadcollection, removecollection, removeshard

        Show
        ASF subversion and git services added a comment - Commit 1669748 from Varun Thacker in branch 'dev/trunk' [ https://svn.apache.org/r1669748 ] SOLR-7202 : Remove deprecated string action types in Overseer, OverseerCollectionProcessor - deletecollection, createcollection, reloadcollection, removecollection, removeshard
        Hide
        ASF subversion and git services added a comment -

        Commit 1669777 from Varun Thacker in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1669777 ]

        SOLR-7202: Remove deprecated string action types in Overseer, OverseerCollectionProcessor - deletecollection, createcollection, reloadcollection, removecollection, removeshard (merging from trunk)

        Show
        ASF subversion and git services added a comment - Commit 1669777 from Varun Thacker in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1669777 ] SOLR-7202 : Remove deprecated string action types in Overseer, OverseerCollectionProcessor - deletecollection, createcollection, reloadcollection, removecollection, removeshard (merging from trunk)
        Hide
        Varun Thacker added a comment -

        Thanks Shalin!

        Show
        Varun Thacker added a comment - Thanks Shalin!
        Hide
        ASF subversion and git services added a comment -

        Commit 1670586 from Varun Thacker in branch 'dev/trunk'
        [ https://svn.apache.org/r1670586 ]

        SOLR-7202: Move CHANGES entry under 5.1

        Show
        ASF subversion and git services added a comment - Commit 1670586 from Varun Thacker in branch 'dev/trunk' [ https://svn.apache.org/r1670586 ] SOLR-7202 : Move CHANGES entry under 5.1
        Hide
        ASF subversion and git services added a comment -

        Commit 1670588 from Varun Thacker in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1670588 ]

        SOLR-7202: Move CHANGES entry under 5.1

        Show
        ASF subversion and git services added a comment - Commit 1670588 from Varun Thacker in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1670588 ] SOLR-7202 : Move CHANGES entry under 5.1
        Hide
        ASF subversion and git services added a comment -

        Commit 1670590 from Varun Thacker in branch 'dev/branches/lucene_solr_5_1'
        [ https://svn.apache.org/r1670590 ]

        SOLR-7202: Move CHANGES entry under 5.1

        Show
        ASF subversion and git services added a comment - Commit 1670590 from Varun Thacker in branch 'dev/branches/lucene_solr_5_1' [ https://svn.apache.org/r1670590 ] SOLR-7202 : Move CHANGES entry under 5.1
        Hide
        Timothy Potter added a comment -

        Bulk close after 5.1 release

        Show
        Timothy Potter added a comment - Bulk close after 5.1 release

          People

          • Assignee:
            Varun Thacker
            Reporter:
            Varun Thacker
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development