Solr
  1. Solr
  2. SOLR-7183

SaslZkACLProviderTest reproducible failures due to poor locale blacklisting

    Details

    • Type: Bug Bug
    • Status: Open
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: 5.2
    • Component/s: None
    • Labels:
      None

      Description

      SaslZkACLProviderTest has this blacklist of locales...

        // These Locales don't generate dates that are compatibile with Hadoop MiniKdc.
        protected final static List<String> brokenLocales =
          Arrays.asList(
            "th_TH_TH_#u-nu-thai",
            "ja_JP_JP_#u-ca-japanese",
            "hi_IN");
      

      ..but this list is incomplete – notably because it only focuses on one specific Thai variant, and then does a string Locale.toString() comparison. so at a minimum -Dtests.locale=th_TH also fails - i suspect there are other variants that will fail as well....

      • if there is a bug in "Hadoop MiniKdc" then that bug should be filed in jira, and there should be Solr jira that refers to it – the Solr jira URL needs to be included her in the test case so developers in the future can understand the context and have some idea of if/when the third-party lib bug is fixed
      • if we need to work around some Locales because of this bug, then Locale comparisons need be based on whatever aspects of the Locale are actually problematic

      see for example SOLR-6387 & this commit: https://svn.apache.org/viewvc/lucene/dev/branches/branch_4x/solr/contrib/morphlines-core/src/test/org/apache/solr/morphlines/solr/AbstractSolrMorphlineZkTestBase.java?r1=1618676&r2=1618675&pathrev=1618676

      Or SOLR-6991 + TIKA-1526 & this commit: https://svn.apache.org/viewvc/lucene/dev/branches/lucene_solr_5_0/solr/contrib/extraction/src/test/org/apache/solr/handler/extraction/ExtractingRequestHandlerTest.java?r1=1653708&r2=1653707&pathrev=1653708

      1. SOLR-7183.patch
        9 kB
        Ishan Chattopadhyaya

        Issue Links

          Activity

          Hide
          Gregory Chanan added a comment -

          DIRAPI-219 may address the underlying issue, I will need to test to verify (and probably push the dependency upgrade to hadoop as well).

          Show
          Gregory Chanan added a comment - DIRAPI-219 may address the underlying issue, I will need to test to verify (and probably push the dependency upgrade to hadoop as well).
          Hide
          Shalin Shekhar Mangar added a comment -

          Also see SOLR-7258 where MessageFormat.format with Number arguments use the default locale and causes problems.

          Show
          Shalin Shekhar Mangar added a comment - Also see SOLR-7258 where MessageFormat.format with Number arguments use the default locale and causes problems.
          Hide
          Anshum Gupta added a comment - - edited

          I think it makes sense to just skip kdc dependent tests when we're running with a blacklisted Locale.

          P.S: I don't have a strong opinion so yes, if you want to save-restore the Locale, go with it.

          Show
          Anshum Gupta added a comment - - edited I think it makes sense to just skip kdc dependent tests when we're running with a blacklisted Locale. P.S: I don't have a strong opinion so yes, if you want to save-restore the Locale, go with it.
          Hide
          Ishan Chattopadhyaya added a comment -

          Patch for bringing all such locale issues in one place, based on Hoss Man suggestions from SOLR-7598.

          Show
          Ishan Chattopadhyaya added a comment - Patch for bringing all such locale issues in one place, based on Hoss Man suggestions from SOLR-7598 .
          Hide
          Anshum Gupta added a comment -

          LGTM. I'll run the tests and commit.

          Show
          Anshum Gupta added a comment - LGTM. I'll run the tests and commit.
          Hide
          ASF subversion and git services added a comment -

          Commit 1681915 from Anshum Gupta in branch 'dev/trunk'
          [ https://svn.apache.org/r1681915 ]

          SOLR-7183: Fix Locale blacklisting for Minikdc based tests.

          Show
          ASF subversion and git services added a comment - Commit 1681915 from Anshum Gupta in branch 'dev/trunk' [ https://svn.apache.org/r1681915 ] SOLR-7183 : Fix Locale blacklisting for Minikdc based tests.
          Hide
          ASF subversion and git services added a comment -

          Commit 1681919 from Anshum Gupta in branch 'dev/branches/branch_5x'
          [ https://svn.apache.org/r1681919 ]

          SOLR-7183: Fix Locale blacklisting for Minikdc based tests.(merge from trunk)

          Show
          ASF subversion and git services added a comment - Commit 1681919 from Anshum Gupta in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1681919 ] SOLR-7183 : Fix Locale blacklisting for Minikdc based tests.(merge from trunk)
          Hide
          ASF subversion and git services added a comment -

          Commit 1681928 from Anshum Gupta in branch 'dev/branches/lucene_solr_5_2'
          [ https://svn.apache.org/r1681928 ]

          SOLR-7183: Fix Locale blacklisting for Minikdc based tests.(merge from branch_5x)

          Show
          ASF subversion and git services added a comment - Commit 1681928 from Anshum Gupta in branch 'dev/branches/lucene_solr_5_2' [ https://svn.apache.org/r1681928 ] SOLR-7183 : Fix Locale blacklisting for Minikdc based tests.(merge from branch_5x)
          Hide
          Uwe Schindler added a comment -

          DIRAPI-219 was solved now. Looks like a bugfix relaese was done!?

          Show
          Uwe Schindler added a comment - DIRAPI-219 was solved now. Looks like a bugfix relaese was done!?
          Hide
          Gregory Chanan added a comment -

          Anshum Gupta should this be marked resolved?

          Show
          Gregory Chanan added a comment - Anshum Gupta should this be marked resolved?
          Hide
          Uwe Schindler added a comment -

          I think we should add a link from this issue to the HadoopMiniKDC issue (if it exists) and then set this issue to state "pending" or like that.

          Show
          Uwe Schindler added a comment - I think we should add a link from this issue to the HadoopMiniKDC issue (if it exists) and then set this issue to state "pending" or like that.
          Hide
          Mark Miller added a comment -

          This test fails a lot on our Jenkins cluster, but it seems unrelated to this, so I've filed SOLR-8544.

          Show
          Mark Miller added a comment - This test fails a lot on our Jenkins cluster, but it seems unrelated to this, so I've filed SOLR-8544 .

            People

            • Assignee:
              Gregory Chanan
              Reporter:
              Hoss Man
            • Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:

                Development