Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-7183

SaslZkACLProviderTest reproducible failures due to poor locale blacklisting

Agile BoardAttach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.2
    • Component/s: None
    • Labels:
      None

      Description

      SaslZkACLProviderTest has this blacklist of locales...

        // These Locales don't generate dates that are compatibile with Hadoop MiniKdc.
        protected final static List<String> brokenLocales =
          Arrays.asList(
            "th_TH_TH_#u-nu-thai",
            "ja_JP_JP_#u-ca-japanese",
            "hi_IN");
      

      ..but this list is incomplete – notably because it only focuses on one specific Thai variant, and then does a string Locale.toString() comparison. so at a minimum -Dtests.locale=th_TH also fails - i suspect there are other variants that will fail as well....

      • if there is a bug in "Hadoop MiniKdc" then that bug should be filed in jira, and there should be Solr jira that refers to it – the Solr jira URL needs to be included her in the test case so developers in the future can understand the context and have some idea of if/when the third-party lib bug is fixed
      • if we need to work around some Locales because of this bug, then Locale comparisons need be based on whatever aspects of the Locale are actually problematic

      see for example SOLR-6387 & this commit: https://svn.apache.org/viewvc/lucene/dev/branches/branch_4x/solr/contrib/morphlines-core/src/test/org/apache/solr/morphlines/solr/AbstractSolrMorphlineZkTestBase.java?r1=1618676&r2=1618675&pathrev=1618676

      Or SOLR-6991 + TIKA-1526 & this commit: https://svn.apache.org/viewvc/lucene/dev/branches/lucene_solr_5_0/solr/contrib/extraction/src/test/org/apache/solr/handler/extraction/ExtractingRequestHandlerTest.java?r1=1653708&r2=1653707&pathrev=1653708

        Attachments

        Issue Links

          Activity

            People

            • Assignee:
              ichattopadhyaya Ishan Chattopadhyaya
              Reporter:
              hossman Chris M. Hostetter

              Dates

              • Created:
                Updated:
                Resolved:

                Issue deployment