Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-7179

JettySolrRunner should not use system properties to pass configuration

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      JettySolrRunner sets a bunch of system properties to pass configuration down to its SolrDispatchFilter and CoreContainer. This means that we can't launch multiple runners at the same time - sys props must be set up, the runner launched, we wait for solr to start up, then sys props must be changed before the next runner can be instantiated.

      Instead we should be able to pass the relevant properties down to SolrDispatchFilter via the servlet context. This will allow MiniSolrCloudCluster and the various ZK test cases to start and stop their jetties in parallel, which will speed up individual tests (and with luck speed up the test suite overall as well).

        Attachments

        1. SOLR-7179.patch
          72 kB
          Alan Woodward
        2. SOLR-7179.patch
          56 kB
          Alan Woodward
        3. SOLR-7179.patch
          42 kB
          Alan Woodward

          Activity

            People

            • Assignee:
              romseygeek Alan Woodward
              Reporter:
              romseygeek Alan Woodward
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: