[SOLR-7178] OverseerAutoReplicaFailoverThread compares Integer objects using ==

• Type: Bug
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 4.10.3, 5.0
• Fix Version/s: 5.1, 6.0
• Component/s: SolrCloud
• Assignee: Shalin Shekhar Mangar
• Reporter: Shalin Shekhar Mangar
• Created: 28/Feb/15 13:22
• Updated: 09/May/16 18:54
• Resolved: 28/Feb/15 13:31

Description

As noted on SOLR-6923, OverseerAutoReplicaFailoverThread has:

if (lastClusterStateVersion == clusterState.getZkClusterStateVersion() && baseUrlForBadNodes.size() == 0 &&
          liveNodes.equals(clusterState.getLiveNodes())) {
...
}

According to JLS this is guaranteed to work only when the integers are between -128 and 127.