Solr
  1. Solr
  2. SOLR-7162

Remove unused SolrSortField interface

    Details

    • Type: Task Task
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.1, 6.0
    • Component/s: None
    • Labels:
      None

      Description

      SortSortField is an unused interface. I can't find any uses in our project. It is also marked as lucene.experimental. Let's nuke it.

      1. SOLR-7162.patch
        1 kB
        Connor Warrington

        Activity

        Hide
        Connor Warrington added a comment -

        I am unable to find this interface.

        Show
        Connor Warrington added a comment - I am unable to find this interface.
        Hide
        Yonik Seeley added a comment -

        Yep, this is left over from when the capability to weight a sort didn't exist in Lucene yet. It was moved to Lucene, but this class wasn't removed.

        Show
        Yonik Seeley added a comment - Yep, this is left over from when the capability to weight a sort didn't exist in Lucene yet. It was moved to Lucene, but this class wasn't removed.
        Hide
        Connor Warrington added a comment -

        Remove unused SolrSortField

        Show
        Connor Warrington added a comment - Remove unused SolrSortField
        Hide
        Connor Warrington added a comment -

        I was confused as the title of the task included SolrSortField yet the description of the task was SortSortField and I couldn't find SortSortField. I've attached a patch to remove the SolrSortField.

        Show
        Connor Warrington added a comment - I was confused as the title of the task included SolrSortField yet the description of the task was SortSortField and I couldn't find SortSortField. I've attached a patch to remove the SolrSortField.
        Hide
        ASF subversion and git services added a comment -

        Commit 1668132 from shalin@apache.org in branch 'dev/trunk'
        [ https://svn.apache.org/r1668132 ]

        SOLR-7162: Remove unused SolrSortField interface

        Show
        ASF subversion and git services added a comment - Commit 1668132 from shalin@apache.org in branch 'dev/trunk' [ https://svn.apache.org/r1668132 ] SOLR-7162 : Remove unused SolrSortField interface
        Hide
        ASF subversion and git services added a comment -

        Commit 1668133 from shalin@apache.org in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1668133 ]

        SOLR-7162: Remove unused SolrSortField interface

        Show
        ASF subversion and git services added a comment - Commit 1668133 from shalin@apache.org in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1668133 ] SOLR-7162 : Remove unused SolrSortField interface
        Hide
        Shalin Shekhar Mangar added a comment -

        Thanks Yonik for the history and to Connor for the patch!

        Show
        Shalin Shekhar Mangar added a comment - Thanks Yonik for the history and to Connor for the patch!
        Hide
        Timothy Potter added a comment -

        Bulk close after 5.1 release

        Show
        Timothy Potter added a comment - Bulk close after 5.1 release

          People

          • Assignee:
            Shalin Shekhar Mangar
            Reporter:
            Shalin Shekhar Mangar
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development