Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-7160

Decouple corecontainer configuration classes from solr.xml

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.1
    • Component/s: None
    • Labels:
      None

      Description

      The ConfigSolr object that holds configuration options for CoreContainer is currently represented as a DOM object, with various methods on it for pulling values out of the DOM tree or out of System properties. This has a couple of drawbacks:
      1) it couples the configuration class directly to its representation on disk, which is a pain if we ever want to change it (say hello, old-style to new-style solr.xml upgrade!).
      2) the checking of system properties means that it's not threadsafe, which in turn means that all our cluster tests have to launch Jettys sequentially, rather than in parallel. This results in tests taking about 25 seconds to start up, before any of the test logic has been run.

      We should tidy this up.

        Attachments

        1. SOLR-7160.patch
          144 kB
          Alan Woodward

          Activity

            People

            • Assignee:
              romseygeek Alan Woodward
              Reporter:
              romseygeek Alan Woodward
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: