Solr
  1. Solr
  2. SOLR-7156

Fix BasicDistributedZk2Test and TestReplicationHandlerBackup failures on Windows

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.1, 6.0
    • Component/s: None
    • Labels:
      None

      Description

      There are failures on Jenkins (Windows), latest one being: http://jenkins.thetaphi.de/job/Lucene-Solr-trunk-Windows/4504/

      It looks like there are some problems during cleanup of certain files, even after the tests have passed.

      1. SOLR-7156.patch
        5 kB
        Ishan Chattopadhyaya
      2. SOLR-7156.patch
        4 kB
        Ishan Chattopadhyaya

        Issue Links

          Activity

          Hide
          Ishan Chattopadhyaya added a comment - - edited

          Attaching a patch fixing test failures due to unclosed directory stream in the tests for Backup functionality, affecting TestReplicationHandlerBackup and BasicDistributedZk2Test.

          Show
          Ishan Chattopadhyaya added a comment - - edited Attaching a patch fixing test failures due to unclosed directory stream in the tests for Backup functionality, affecting TestReplicationHandlerBackup and BasicDistributedZk2Test.
          Hide
          Shalin Shekhar Mangar added a comment -

          Thanks Ishan!

          Let's use the try-with-resources construct to close these DirectoryStream objects automatically after use.

          Show
          Shalin Shekhar Mangar added a comment - Thanks Ishan! Let's use the try-with-resources construct to close these DirectoryStream objects automatically after use.
          Hide
          Ishan Chattopadhyaya added a comment -

          Thanks Shalin for the pointer to try-with-resources. I've updated the patch.

          Show
          Ishan Chattopadhyaya added a comment - Thanks Shalin for the pointer to try-with-resources. I've updated the patch.
          Hide
          ASF subversion and git services added a comment -

          Commit 1662174 from shalin@apache.org in branch 'dev/trunk'
          [ https://svn.apache.org/r1662174 ]

          SOLR-7156: Fix test failures due to resource leaks on windows

          Show
          ASF subversion and git services added a comment - Commit 1662174 from shalin@apache.org in branch 'dev/trunk' [ https://svn.apache.org/r1662174 ] SOLR-7156 : Fix test failures due to resource leaks on windows
          Hide
          ASF subversion and git services added a comment -

          Commit 1662176 from shalin@apache.org in branch 'dev/branches/branch_5x'
          [ https://svn.apache.org/r1662176 ]

          SOLR-7156: Fix test failures due to resource leaks on windows

          Show
          ASF subversion and git services added a comment - Commit 1662176 from shalin@apache.org in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1662176 ] SOLR-7156 : Fix test failures due to resource leaks on windows
          Hide
          Shalin Shekhar Mangar added a comment -

          Thanks Ishan!

          Show
          Shalin Shekhar Mangar added a comment - Thanks Ishan!
          Hide
          Timothy Potter added a comment -

          Bulk close after 5.1 release

          Show
          Timothy Potter added a comment - Bulk close after 5.1 release

            People

            • Assignee:
              Shalin Shekhar Mangar
              Reporter:
              Ishan Chattopadhyaya
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development