Is it ok to kill the whole operation from inside of a debug block?
From my perspective I'd rather that as I'm more likely to notice there is an issue. Probably nicer for the end user to chug along though.
Is this related, or just incidental test cleanup?
Rarely, shutting down hdfs can throw an exception - in some cases because it cannot find a class it wants, in other cases a null pointer exception - starting and stopping hdfs test issues are outside of what we are testing though - it shouldn't randomly fail our chaosmonkey tests.
No reason to remove this constructor, I think.
I'd rather force devs to pay attention to the other params they use than offer more constructors here.
Why is there a difference?
Tests can last much too long if when we have no pauses between updates and we allow too many updates. When there are pauses, its not so bad, but the pauses can be so short (it's random), we still want to have some upper limit. This is probably a result of log replay not being able to keep up with updates coming.
Possibly worth logging which core?
It's always worth doing this everywhere, but since we do it so little already (except when you use our special test logger, which tries to figure it out), I've been waiting for a more holistic fix rather doing ad hoc fixes. No real pain adding it here though.