Solr
  1. Solr
  2. SOLR-7112

DeleteInactiveReplicaTest.deleteLiveReplicaTest test failures

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 5.0
    • Fix Version/s: 5.1, 6.0
    • Component/s: Tests
    • Labels:
      None

      Description

      java.lang.AssertionError: Should have had a good message here
      	at __randomizedtesting.SeedInfo.seed([E27AFA625D3D168A:4F1A4E694002BEFF]:0)
      	at org.junit.Assert.fail(Assert.java:93)
      	at org.junit.Assert.assertTrue(Assert.java:43)
      	at org.apache.solr.cloud.DeleteReplicaTest.deleteLiveReplicaTest(DeleteReplicaTest.java:125)
      	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
      

      This fails very frequently on jenkins.

      1. SOLR-7112.patch
        4 kB
        Shalin Shekhar Mangar

        Activity

        Hide
        Shalin Shekhar Mangar added a comment -

        The test method deleteLiveReplicaTest actually belongs to the parent class DeleteReplicaTest.

        I think started happening after SOLR-6902. The DeleteInactiveReplicaTest extends the DeleteReplicaTest and used to override the doTest method. After SOLR-6902 we started using annotations and now the test methods in the parent class are also executed as part of this test. But the parent sets sliceCount=2 and sets checkCreatedVsState flag to false which DeleteInactiveReplicaTest doesn't and hence the odd failure.

        I'll fix by not inheriting from that class. There's just two methods being shared and they can easily be made package private. A cleanup of these cloud tests is due but that will need it's own issue.

        Show
        Shalin Shekhar Mangar added a comment - The test method deleteLiveReplicaTest actually belongs to the parent class DeleteReplicaTest. I think started happening after SOLR-6902 . The DeleteInactiveReplicaTest extends the DeleteReplicaTest and used to override the doTest method. After SOLR-6902 we started using annotations and now the test methods in the parent class are also executed as part of this test. But the parent sets sliceCount=2 and sets checkCreatedVsState flag to false which DeleteInactiveReplicaTest doesn't and hence the odd failure. I'll fix by not inheriting from that class. There's just two methods being shared and they can easily be made package private. A cleanup of these cloud tests is due but that will need it's own issue.
        Hide
        Shalin Shekhar Mangar added a comment -

        DeleteInactiveReplicaTest extends AbstractFullDistribZkTestBase instead of DeleteReplicaTest.

        Show
        Shalin Shekhar Mangar added a comment - DeleteInactiveReplicaTest extends AbstractFullDistribZkTestBase instead of DeleteReplicaTest.
        Hide
        ASF subversion and git services added a comment -

        Commit 1659850 from shalin@apache.org in branch 'dev/trunk'
        [ https://svn.apache.org/r1659850 ]

        SOLR-7112: Fix DeleteInactiveReplicaTest.deleteLiveReplicaTest test failures

        Show
        ASF subversion and git services added a comment - Commit 1659850 from shalin@apache.org in branch 'dev/trunk' [ https://svn.apache.org/r1659850 ] SOLR-7112 : Fix DeleteInactiveReplicaTest.deleteLiveReplicaTest test failures
        Hide
        ASF subversion and git services added a comment -

        Commit 1659851 from shalin@apache.org in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1659851 ]

        SOLR-7112: Fix DeleteInactiveReplicaTest.deleteLiveReplicaTest test failures

        Show
        ASF subversion and git services added a comment - Commit 1659851 from shalin@apache.org in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1659851 ] SOLR-7112 : Fix DeleteInactiveReplicaTest.deleteLiveReplicaTest test failures
        Hide
        Shalin Shekhar Mangar added a comment -

        I'm pretty sure this has fixed the failure. I beasted this test as well as the parent test 20 times each. I'll resolve this and I'll keep an eye out on jenkins.

        Show
        Shalin Shekhar Mangar added a comment - I'm pretty sure this has fixed the failure. I beasted this test as well as the parent test 20 times each. I'll resolve this and I'll keep an eye out on jenkins.
        Hide
        Timothy Potter added a comment -

        Bulk close after 5.1 release

        Show
        Timothy Potter added a comment - Bulk close after 5.1 release

          People

          • Assignee:
            Shalin Shekhar Mangar
            Reporter:
            Shalin Shekhar Mangar
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development