Solr
  1. Solr
  2. SOLR-7104

AddReplica Collection API call discards all the property prefix parameters

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 5.0
    • Fix Version/s: 5.1, 6.0
    • Component/s: None
    • Labels:
      None

      Description

      CollectionsHandler.handleAddReplica does not call copyPropertiesIfNotNull . This means all the property prefix values are discarded.

      It's behaviour is documented in the ref guide https://cwiki.apache.org/confluence/display/solr/Collections+API#CollectionsAPI-api_addreplica .

      1. SOLR-7104.patch
        3 kB
        Varun Thacker

        Activity

        Hide
        Varun Thacker added a comment -

        Path where the property. prefix values will not be ignored by ADDREPLICA call.

        CollectionsAPIDistributedZkTest.addReplicaTest() never seems to be called. Patch enables it and uses the property.key param to test if it's working as expected.

        Show
        Varun Thacker added a comment - Path where the property. prefix values will not be ignored by ADDREPLICA call. CollectionsAPIDistributedZkTest.addReplicaTest() never seems to be called. Patch enables it and uses the property.key param to test if it's working as expected.
        Hide
        Anshum Gupta added a comment -

        LGTM. I'll commit this after running the tests.
        Thanks Varun.

        Show
        Anshum Gupta added a comment - LGTM. I'll commit this after running the tests. Thanks Varun.
        Hide
        Anshum Gupta added a comment -

        Thanks Varun!

        Show
        Anshum Gupta added a comment - Thanks Varun!
        Hide
        ASF subversion and git services added a comment -

        Commit 1660551 from Anshum Gupta in branch 'dev/trunk'
        [ https://svn.apache.org/r1660551 ]

        SOLR-7104: Propagate property prefix params for ADDREPLICA

        Show
        ASF subversion and git services added a comment - Commit 1660551 from Anshum Gupta in branch 'dev/trunk' [ https://svn.apache.org/r1660551 ] SOLR-7104 : Propagate property prefix params for ADDREPLICA
        Hide
        ASF subversion and git services added a comment -

        Commit 1660552 from Anshum Gupta in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1660552 ]

        SOLR-7104: Propagate property prefix params for ADDREPLICA (merge from trunk)

        Show
        ASF subversion and git services added a comment - Commit 1660552 from Anshum Gupta in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1660552 ] SOLR-7104 : Propagate property prefix params for ADDREPLICA (merge from trunk)
        Hide
        Timothy Potter added a comment -

        Bulk close after 5.1 release

        Show
        Timothy Potter added a comment - Bulk close after 5.1 release

          People

          • Assignee:
            Anshum Gupta
            Reporter:
            Varun Thacker
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development