[SOLR-7033] RecoveryStrategy should not publish any state when closed / cancelled.

• Type: Bug
• Status: Closed
• Priority: Blocker
• Resolution: Fixed
• Fix Version/s: 4.10.4, 5.0, 6.0
• Assignee: Steven Rowe
• Reporter: Mark Miller
• Created: 26/Jan/15 03:29
• Updated: 09/May/16 18:53
• Resolved: 27/Feb/15 18:46

Description

Currently, when closed / cancelled, RecoveryStrategy can publish a recovery failed state. In a bad loop (like when no one can become leader because no one had a last state of active) this can cause very fast looped publishing of this state to zk.

It's an outstanding item to improve that specific scenario anyway, but regardless, we should fix the close / cancel path to never publish any state to zk.

Issue Links

• is related to: SOLR-5961 Solr gets crazy on /overseer/queue state change
• is related to: SOLR-7285 ActionThrottle will not pause if getNanoTime first returns 0.
• is related to: SOLR-8371 Try and prevent too many recovery requests from stacking up and clean up some faulty logic.
• relates to: SOLR-7034 Consider allowing any node to become leader, regardless of their last published state.