Solr
  1. Solr
  2. SOLR-7014

Collapse identical catch branches in try-catch statements

    Details

    • Type: Task Task
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.1, 6.0
    • Component/s: None
    • Labels:
      None

      Description

      We are on Java 7+ so we can reduce verbosity by collapsing identical catch statements into one.

      1. SOLR-7014.patch
        35 kB
        Shalin Shekhar Mangar
      2. SOLR-7014-more.patch
        4 kB
        Shalin Shekhar Mangar

        Issue Links

          Activity

          Hide
          Shalin Shekhar Mangar added a comment -

          This takes care of all solr classes. I'll attach another one which does the same for lucene.

          Show
          Shalin Shekhar Mangar added a comment - This takes care of all solr classes. I'll attach another one which does the same for lucene.
          Hide
          ASF subversion and git services added a comment -

          Commit 1653665 from shalin@apache.org in branch 'dev/trunk'
          [ https://svn.apache.org/r1653665 ]

          SOLR-7014: Collapse identical catch branches in try-catch statements

          Show
          ASF subversion and git services added a comment - Commit 1653665 from shalin@apache.org in branch 'dev/trunk' [ https://svn.apache.org/r1653665 ] SOLR-7014 : Collapse identical catch branches in try-catch statements
          Hide
          ASF subversion and git services added a comment -

          Commit 1653688 from shalin@apache.org in branch 'dev/branches/branch_5x'
          [ https://svn.apache.org/r1653688 ]

          SOLR-7014: Collapse identical catch branches in try-catch statements

          Show
          ASF subversion and git services added a comment - Commit 1653688 from shalin@apache.org in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1653688 ] SOLR-7014 : Collapse identical catch branches in try-catch statements
          Hide
          Shalin Shekhar Mangar added a comment -

          I had missed some classes in solr-morphlines.

          Show
          Shalin Shekhar Mangar added a comment - I had missed some classes in solr-morphlines.
          Hide
          ASF subversion and git services added a comment -

          Commit 1653697 from shalin@apache.org in branch 'dev/trunk'
          [ https://svn.apache.org/r1653697 ]

          SOLR-7014: Collapse identical catch branches in try-catch statements in morphlines-core

          Show
          ASF subversion and git services added a comment - Commit 1653697 from shalin@apache.org in branch 'dev/trunk' [ https://svn.apache.org/r1653697 ] SOLR-7014 : Collapse identical catch branches in try-catch statements in morphlines-core
          Hide
          ASF subversion and git services added a comment -

          Commit 1653698 from shalin@apache.org in branch 'dev/branches/branch_5x'
          [ https://svn.apache.org/r1653698 ]

          SOLR-7014: Collapse identical catch branches in try-catch statements in morphlines-core

          Show
          ASF subversion and git services added a comment - Commit 1653698 from shalin@apache.org in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1653698 ] SOLR-7014 : Collapse identical catch branches in try-catch statements in morphlines-core
          Hide
          Shalin Shekhar Mangar added a comment -

          I opened LUCENE-6193 for the lucene changes.

          Show
          Shalin Shekhar Mangar added a comment - I opened LUCENE-6193 for the lucene changes.
          Hide
          Timothy Potter added a comment -

          Bulk close after 5.1 release

          Show
          Timothy Potter added a comment - Bulk close after 5.1 release

            People

            • Assignee:
              Shalin Shekhar Mangar
              Reporter:
              Shalin Shekhar Mangar
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development