Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-7010

Remove facet.date client functionality from master

    Details

    • Type: Task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 6.0, master (7.0)
    • Component/s: None
    • Labels:
      None

      Description

      See comments in SOLR-6976. We should log a warning when a client using 5.x includes a facet.date param (both in the solr log, and in the response), and remove the functionality entirely from trunk.

      1. SOLR-7010.patch
        51 kB
        Steve Rowe
      2. SOLR-7010.patch
        50 kB
        Steve Rowe

        Activity

        Hide
        steve_rowe Steve Rowe added a comment -

        First cut at a patch. Haven't fully compiled/tested yet.

        AFAICT we never provided deprecation warnings on responses in 5.x, but does that mean we should wait until 7.0 before we finally remove facet.date stuff?

        Show
        steve_rowe Steve Rowe added a comment - First cut at a patch. Haven't fully compiled/tested yet. AFAICT we never provided deprecation warnings on responses in 5.x, but does that mean we should wait until 7.0 before we finally remove facet.date stuff?
        Hide
        shalinmangar Shalin Shekhar Mangar added a comment -

        facet.date was deprecated in 3.1.0, I think we should just remove them completely.

        Show
        shalinmangar Shalin Shekhar Mangar added a comment - facet.date was deprecated in 3.1.0, I think we should just remove them completely.
        Hide
        steve_rowe Steve Rowe added a comment -

        Patch, fixes a few failing tests and adds a CHANGES.txt entry.

        Tests and precommit pass.

        I think it's ready to go. If there are no objections I'll commit later today.

        Show
        steve_rowe Steve Rowe added a comment - Patch, fixes a few failing tests and adds a CHANGES.txt entry. Tests and precommit pass. I think it's ready to go. If there are no objections I'll commit later today.
        Hide
        steve_rowe Steve Rowe added a comment -

        +1

        Show
        steve_rowe Steve Rowe added a comment - +1
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit d0279b8d5f6c2b4a640ac4738d63a1da0cd79005 in lucene-solr's branch refs/heads/master from Steve Rowe
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=d0279b8 ]

        SOLR-7010: Remove facet.date client functionality

        Show
        jira-bot ASF subversion and git services added a comment - Commit d0279b8d5f6c2b4a640ac4738d63a1da0cd79005 in lucene-solr's branch refs/heads/master from Steve Rowe [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=d0279b8 ] SOLR-7010 : Remove facet.date client functionality
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit d0d75c448ed78b928af3c8f20ded210ce102d4d4 in lucene-solr's branch refs/heads/branch_6x from Steve Rowe
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=d0d75c4 ]

        SOLR-7010: Remove facet.date client functionality

        Show
        jira-bot ASF subversion and git services added a comment - Commit d0d75c448ed78b928af3c8f20ded210ce102d4d4 in lucene-solr's branch refs/heads/branch_6x from Steve Rowe [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=d0d75c4 ] SOLR-7010 : Remove facet.date client functionality
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 79a7008b7206123821367e78b95ff2b86ae308a3 in lucene-solr's branch refs/heads/branch_6_0 from Steve Rowe
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=79a7008 ]

        SOLR-7010: Remove facet.date client functionality

        Show
        jira-bot ASF subversion and git services added a comment - Commit 79a7008b7206123821367e78b95ff2b86ae308a3 in lucene-solr's branch refs/heads/branch_6_0 from Steve Rowe [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=79a7008 ] SOLR-7010 : Remove facet.date client functionality
        Hide
        hossman Hoss Man added a comment -

        Manually correcting fixVersion per Step #S6 of LUCENE-7271

        Show
        hossman Hoss Man added a comment - Manually correcting fixVersion per Step #S6 of LUCENE-7271

          People

          • Assignee:
            steve_rowe Steve Rowe
            Reporter:
            romseygeek Alan Woodward
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development