Solr
  1. Solr
  2. SOLR-7007

DistributedUpdateProcessor logs replay status as int instead of boolean

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 4.10.3
    • Fix Version/s: 5.4, 6.0
    • Component/s: replication (java)
    • Labels:

      Description

      When logging the following line:

      DistributedUpdateProcessor.java
              log.info("Ignoring commit while not ACTIVE - state: " + ulog.getState() + " replay:" + (cmd.getFlags() & UpdateCommand.REPLAY));
      

      We display the value of the replay flag as an int instead of a boolean. This can erroneously lead operators to believe that it is a counter instead of a flag when all they see is the log.

        Activity

        Hide
        Mike Drob added a comment -

        One-line patch to log as a boolean instead of an int. Applies cleanly to all branches, probably safe for trunk and 5x.

        Show
        Mike Drob added a comment - One-line patch to log as a boolean instead of an int. Applies cleanly to all branches, probably safe for trunk and 5x.
        Hide
        ASF subversion and git services added a comment -

        Commit 1696852 from Christine Poerschke in branch 'dev/trunk'
        [ https://svn.apache.org/r1696852 ]

        SOLR-7007: DistributedUpdateProcessor now logs replay flag as boolean instead of int

        Show
        ASF subversion and git services added a comment - Commit 1696852 from Christine Poerschke in branch 'dev/trunk' [ https://svn.apache.org/r1696852 ] SOLR-7007 : DistributedUpdateProcessor now logs replay flag as boolean instead of int
        Hide
        ASF subversion and git services added a comment -

        Commit 1696853 from Christine Poerschke in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1696853 ]

        SOLR-7007: DistributedUpdateProcessor now logs replay flag as boolean instead of int (merge in revision 1696852 from trunk)

        Show
        ASF subversion and git services added a comment - Commit 1696853 from Christine Poerschke in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1696853 ] SOLR-7007 : DistributedUpdateProcessor now logs replay flag as boolean instead of int (merge in revision 1696852 from trunk)
        Hide
        Christine Poerschke added a comment -

        Thanks Mike!

        Show
        Christine Poerschke added a comment - Thanks Mike!

          People

          • Assignee:
            Christine Poerschke
            Reporter:
            Mike Drob
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development