Solr
  1. Solr
  2. SOLR-6

Solr admin stylesheet doesn't work well with Internet Explorer

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.1.0
    • Component/s: web gui
    • Labels:
      None

      Description

      The admin pages look different on firefox than on IE (6 or 7).

      • tables in text analysis page span whole browser, regardless of cell size
      • separators visible in firefox aren't visible in IE
      1. iestyles.patch
        5 kB
        Greg Ludington

        Activity

        Hide
        Hoss Man added a comment -

        This bug was modified as part of a bulk update using the criteria...

        • Marked ("Resolved" or "Closed") and "Fixed"
        • Had no "Fix Version" versions
        • Was listed in the CHANGES.txt for 1.1

        The Fix Version for all 38 issues found was set to 1.1, email notification
        was suppressed to prevent excessive email.

        For a list of all the issues modified, search jira comments for this
        (hopefully) unique string: 20080415hossman3

        Show
        Hoss Man added a comment - This bug was modified as part of a bulk update using the criteria... Marked ("Resolved" or "Closed") and "Fixed" Had no "Fix Version" versions Was listed in the CHANGES.txt for 1.1 The Fix Version for all 38 issues found was set to 1.1, email notification was suppressed to prevent excessive email. For a list of all the issues modified, search jira comments for this (hopefully) unique string: 20080415hossman3
        Hide
        Bill Au added a comment -

        Committed revision 420815.

        Show
        Bill Au added a comment - Committed revision 420815.
        Hide
        Bill Au added a comment -

        Looks good for both IE6 and IE7. I have commited the changes.
        Thanks Greg for your contribution.

        Show
        Bill Au added a comment - Looks good for both IE6 and IE7. I have commited the changes. Thanks Greg for your contribution.
        Hide
        Greg Ludington added a comment -

        Wonky is the correct word – if the border-left is one pixel, it shows as white. If it is two pixels, the color shows. A border-right appears to work even with only one pixel. Maybe IE7 gets it right, but not IE6

        If you are going to continue to have two column analysis tables, and the first column is a th, adding this appears to do the trick in both IE6 and Firefox 1.5:

        table.analysis th

        { border-right:1px solid #ff9933; }
        Show
        Greg Ludington added a comment - Wonky is the correct word – if the border-left is one pixel, it shows as white. If it is two pixels, the color shows. A border-right appears to work even with only one pixel. Maybe IE7 gets it right, but not IE6 If you are going to continue to have two column analysis tables, and the first column is a th, adding this appears to do the trick in both IE6 and Firefox 1.5: table.analysis th { border-right:1px solid #ff9933; }
        Hide
        Hoss Man added a comment -

        Greg, thanks for the patch!

        One thing that's still a little wonky is the verticle cell dividers (left/right borders i guess?) on the analysis.jsp page. In firefox they show up as black lines, but in IE they are white.

        if you've got any suggestions on what's causing that i think we could consider this bad boy resolved.

        (i tried adding the seemingly obvious...

        border-left: 1px solid #ff0000
        border-right: 1px solid #ff0000

        ...to "th, td", and "td.debugdata, td.highlight, td.responseHeader" with no success)

        Show
        Hoss Man added a comment - Greg, thanks for the patch! One thing that's still a little wonky is the verticle cell dividers (left/right borders i guess?) on the analysis.jsp page. In firefox they show up as black lines, but in IE they are white. if you've got any suggestions on what's causing that i think we could consider this bad boy resolved. (i tried adding the seemingly obvious... border-left: 1px solid #ff0000 border-right: 1px solid #ff0000 ...to "th, td", and "td.debugdata, td.highlight, td.responseHeader" with no success)
        Hide
        Greg Ludington added a comment -

        The visual differences occur because IE 6 (I do not have IE7 to test) does not seem to apply border to rows, only to cells, and also does not understand some of the more advanced selectors you have used, such as XSLT-ish select by attributes, or by child and adjacent sibling. I am a new user to solr, but this seemed like a low-risk area where I could pitch in and help.

        This proposed patch puts the relevant css information into regular css classes, and then adjusts the jsps to match, e.g. instead of
        tr > td[name="highlight"]:first-child

        you have
        td.highlight

        The meanings are slightly different, and they apply to a broader range of HTML, but it improves the look in IE and did not seem to have any negative impact in Firefox 1.5.0.4. I did not migrate every css2 selector over to a class this way, but just those that made a large difference in the way IE6 rendered the page without resorting to css hackery.

        If I missed any locations, or their are awkward results in this style, feel free to comment. I purposely did not make any effort to modify tabular.xsl, as this thread indicates it is deprecated:

        http://www.nabble.com/stylesheet-issue-tf1721121.html#a4675018

        Show
        Greg Ludington added a comment - The visual differences occur because IE 6 (I do not have IE7 to test) does not seem to apply border to rows, only to cells, and also does not understand some of the more advanced selectors you have used, such as XSLT-ish select by attributes, or by child and adjacent sibling. I am a new user to solr, but this seemed like a low-risk area where I could pitch in and help. This proposed patch puts the relevant css information into regular css classes, and then adjusts the jsps to match, e.g. instead of tr > td [name="highlight"] :first-child you have td.highlight The meanings are slightly different, and they apply to a broader range of HTML, but it improves the look in IE and did not seem to have any negative impact in Firefox 1.5.0.4. I did not migrate every css2 selector over to a class this way, but just those that made a large difference in the way IE6 rendered the page without resorting to css hackery. If I missed any locations, or their are awkward results in this style, feel free to comment. I purposely did not make any effort to modify tabular.xsl, as this thread indicates it is deprecated: http://www.nabble.com/stylesheet-issue-tf1721121.html#a4675018

          People

          • Assignee:
            Bill Au
            Reporter:
            Yonik Seeley
          • Votes:
            1 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development