Solr
  1. Solr
  2. SOLR-6992

ShowFileRequestHandler is hiding dynamic schema file even in read-only mode

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 5.0
    • Fix Version/s: 5.5, 6.0
    • Component/s: None
    • Labels:
      None

      Description

      When using dynamic schema, the schema file is not shown in the admin UI (Files tab) by default. It is hidden because (as per the section comment):

      // Make sure that if the schema is managed, we don't allow editing.

      But we don't have editing interface for those files (SOLR-5287 was backed out), so the reason is not valid and makes reviewing schema just that bit harder.

      The fix is probably just editing out that section, unless there are tests specifically for that.

      1. SOLR-6992.patch
        3 kB
        Varun Thacker
      2. SOLR-6992.patch
        0.9 kB
        Shawn Heisey

        Issue Links

          Activity

          Hide
          Alexandre Rafalovitch added a comment -

          Could someone please review this.
          It really present inconsistent "Files" view in Admin UI when comparing data-driven and schema.xml style cores.

          Show
          Alexandre Rafalovitch added a comment - Could someone please review this. It really present inconsistent "Files" view in Admin UI when comparing data-driven and schema.xml style cores.
          Hide
          Shawn Heisey added a comment -

          Patch. I may not be able to get to this today. I've got some cleanup to do for differences between trunk and 5x CHANGES.txt.

          Show
          Shawn Heisey added a comment - Patch. I may not be able to get to this today. I've got some cleanup to do for differences between trunk and 5x CHANGES.txt.
          Hide
          Alexandre Rafalovitch added a comment -

          So, I guess we are not making this one into 5.4? We should at least fix the headers for the next time then.

          Show
          Alexandre Rafalovitch added a comment - So, I guess we are not making this one into 5.4? We should at least fix the headers for the next time then.
          Hide
          Varun Thacker added a comment -

          Hi Shawn Heisey,

          I tried out the patch. The `managed-schema` file does come up but clicking on it still doesn't show the data within it. Digging into why

          Show
          Varun Thacker added a comment - Hi Shawn Heisey , I tried out the patch. The `managed-schema` file does come up but clicking on it still doesn't show the data within it. Digging into why
          Hide
          Varun Thacker added a comment -

          Updated patch. There was some Javascript tweaking required to get it working.

          Would appreciate some feedback on the Javascript part from Upayavira or Stefan Matheis (steffkes)

          Show
          Varun Thacker added a comment - Updated patch. There was some Javascript tweaking required to get it working. Would appreciate some feedback on the Javascript part from Upayavira or Stefan Matheis (steffkes)
          Hide
          Upayavira added a comment -

          This all looks good to me.

          Show
          Upayavira added a comment - This all looks good to me.
          Hide
          Varun Thacker added a comment -

          Thanks Upayavira !

          Shawn, would you like to commit it? Else I can

          Show
          Varun Thacker added a comment - Thanks Upayavira ! Shawn, would you like to commit it? Else I can
          Hide
          Shawn Heisey added a comment -

          Go ahead. I'm finding my availability lately to be low. It's irritating when $JOB and $LIFE intrude.

          Show
          Shawn Heisey added a comment - Go ahead. I'm finding my availability lately to be low. It's irritating when $JOB and $LIFE intrude.
          Hide
          ASF subversion and git services added a comment -

          Commit 1719261 from Varun Thacker in branch 'dev/trunk'
          [ https://svn.apache.org/r1719261 ]

          SOLR-6992: Fix Files UI to show the managed-schema file as well

          Show
          ASF subversion and git services added a comment - Commit 1719261 from Varun Thacker in branch 'dev/trunk' [ https://svn.apache.org/r1719261 ] SOLR-6992 : Fix Files UI to show the managed-schema file as well
          Hide
          ASF subversion and git services added a comment -

          Commit 1719263 from Varun Thacker in branch 'dev/branches/branch_5x'
          [ https://svn.apache.org/r1719263 ]

          SOLR-6992: Fix Files UI to show the managed-schema file as well (merged trunk r1719261)

          Show
          ASF subversion and git services added a comment - Commit 1719263 from Varun Thacker in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1719263 ] SOLR-6992 : Fix Files UI to show the managed-schema file as well (merged trunk r1719261)
          Hide
          Varun Thacker added a comment -

          Thanks Alexandre!

          Show
          Varun Thacker added a comment - Thanks Alexandre!

            People

            • Assignee:
              Varun Thacker
              Reporter:
              Alexandre Rafalovitch
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development