Solr
  1. Solr
  2. SOLR-6976

Remove all methods and classes deprecated in 4.x from trunk and 5.x

    Details

    • Type: Task Task
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.0, 6.0
    • Component/s: None
    • Labels:
      None

      Description

      We have a bunch of methods, classes, enums, etc which are marked as deprecated in Solr code in the 4.x branch. Some of them have been marked as such since the 1.4 release. Before we get 5.0 out, these should all be removed

      1. SOLR-6976.patch
        176 kB
        Alan Woodward
      2. SOLR-6976.patch
        164 kB
        Alan Woodward
      3. SOLR-6976.patch
        155 kB
        Alan Woodward
      4. SOLR-sharkeys.patch
        2 kB
        Noble Paul

        Activity

        Hide
        Mark Miller added a comment -

        +1.

        Show
        Mark Miller added a comment - +1.
        Hide
        Alan Woodward added a comment -
        solr git:(lucene_solr_4_10) $ ack --java '@Deprecated'
        contrib/clustering/src/java/org/apache/solr/handler/clustering/carrot2/CarrotParams.java
        53:  @Deprecated
        
        contrib/dataimporthandler/src/java/org/apache/solr/handler/dataimport/CachedSqlEntityProcessor.java
        34:@Deprecated
        
        contrib/dataimporthandler/src/java/org/apache/solr/handler/dataimport/config/ConfigNameConstants.java
        37:  @Deprecated
        
        contrib/dataimporthandler/src/java/org/apache/solr/handler/dataimport/HttpDataSource.java
        36:@Deprecated
        
        contrib/map-reduce/src/test/org/apache/solr/hadoop/hack/MiniMRCluster.java
        50:@Deprecated
        
        core/src/java/org/apache/solr/analysis/LegacyHTMLStripCharFilter.java
        49:@Deprecated
        
        core/src/java/org/apache/solr/analysis/LegacyHTMLStripCharFilterFactory.java
        55:@Deprecated
        
        core/src/java/org/apache/solr/analysis/SolrAnalyzer.java
        41:  @Deprecated
        
        core/src/java/org/apache/solr/client/solrj/embedded/EmbeddedSolrServer.java
        67:  @Deprecated
        238:  @Deprecated
        
        core/src/java/org/apache/solr/cloud/OverseerCollectionProcessor.java
        108:  // @Deprecated- see on ZkStateReader
        111:  // @Deprecated- see on ZkStateReader
        
        core/src/java/org/apache/solr/common/ResourceLoader.java
        24:@Deprecated
        
        core/src/java/org/apache/solr/core/CoreContainer.java
        803:  @Deprecated
        
        core/src/java/org/apache/solr/core/SolrConfig.java
        384:  @Deprecated
        386:  @Deprecated
        
        core/src/java/org/apache/solr/handler/admin/CoreAdminHandler.java
        658:  @Deprecated
        
        core/src/java/org/apache/solr/handler/BinaryUpdateRequestHandler.java
        30:@Deprecated
        
        core/src/java/org/apache/solr/handler/CSVRequestHandler.java
        25:@Deprecated
        
        core/src/java/org/apache/solr/handler/JsonUpdateRequestHandler.java
        25:@Deprecated
        
        core/src/java/org/apache/solr/handler/MoreLikeThisHandler.java
        387:    @Deprecated
        
        core/src/java/org/apache/solr/handler/XmlUpdateRequestHandler.java
        27:@Deprecated
        
        core/src/java/org/apache/solr/handler/XsltUpdateRequestHandler.java
        27:@Deprecated
        
        core/src/java/org/apache/solr/highlight/DefaultSolrHighlighter.java
        146:  @Deprecated
        
        core/src/java/org/apache/solr/highlight/SolrHighlighter.java
        41:  @Deprecated
        
        core/src/java/org/apache/solr/parser/CharStream.java
        30:  @Deprecated
        38:  @Deprecated
        
        core/src/java/org/apache/solr/request/SimpleFacets.java
        999:  @Deprecated
        1018:  @Deprecated
        1394:  @Deprecated
        
        core/src/java/org/apache/solr/rest/schema/analysis/FSTSynonymFilterFactory.java
        53:@Deprecated
        
        core/src/java/org/apache/solr/schema/BCDIntField.java
        31:@Deprecated
        
        core/src/java/org/apache/solr/schema/BCDLongField.java
        24:@Deprecated
        
        core/src/java/org/apache/solr/schema/BCDStrField.java
        24:@Deprecated
        
        core/src/java/org/apache/solr/schema/ByteField.java
        50:@Deprecated
        
        core/src/java/org/apache/solr/schema/DateField.java
        113:@Deprecated
        272:  @Deprecated
        
        core/src/java/org/apache/solr/schema/DoubleField.java
        46:@Deprecated
        
        core/src/java/org/apache/solr/schema/FieldType.java
        496:  @Deprecated
        545:  @Deprecated
        
        core/src/java/org/apache/solr/schema/FloatField.java
        45:@Deprecated
        
        core/src/java/org/apache/solr/schema/IndexSchema.java
        278:  @Deprecated
        
        core/src/java/org/apache/solr/schema/IntField.java
        45:@Deprecated
        
        core/src/java/org/apache/solr/schema/LongField.java
        45:@Deprecated
        
        core/src/java/org/apache/solr/schema/SchemaField.java
        100:  @Deprecated
        
        core/src/java/org/apache/solr/schema/ShortField.java
        51:@Deprecated
        
        core/src/java/org/apache/solr/schema/SortableDoubleField.java
        55:@Deprecated
        128:@Deprecated
        
        core/src/java/org/apache/solr/schema/SortableFloatField.java
        56:@Deprecated
        130:@Deprecated
        
        core/src/java/org/apache/solr/schema/SortableIntField.java
        56:@Deprecated
        133:@Deprecated
        
        core/src/java/org/apache/solr/schema/SortableLongField.java
        55:@Deprecated
        129:@Deprecated
        
        core/src/java/org/apache/solr/schema/TrieField.java
        358:  @Deprecated
        363:  @Deprecated
        
        core/src/java/org/apache/solr/search/QueryParsing.java
        230:  @Deprecated
        
        core/src/java/org/apache/solr/search/SortSpec.java
        48:  @Deprecated
        54:  @Deprecated
        62:  @Deprecated
        
        core/src/java/org/apache/solr/update/processor/FieldMutatingUpdateProcessorFactory.java
        254:  @Deprecated
        294:  @Deprecated
        
        core/src/java/org/apache/solr/update/SolrIndexConfig.java
        55:  @Deprecated
        
        core/src/java/org/apache/solr/util/BCDUtils.java
        24:@Deprecated
        
        core/src/java/org/apache/solr/util/plugin/ResourceLoaderAware.java
        24:@Deprecated
        
        core/src/test/org/apache/solr/core/ResourceLoaderTest.java
        219:  @Deprecated
        
        solrj/src/java/org/apache/solr/client/solrj/request/CoreAdminRequest.java
        590:  @Deprecated
        
        solrj/src/java/org/apache/solr/client/solrj/response/RangeFacet.java
        87:    @Deprecated
        100:    @Deprecated
        
        solrj/src/java/org/apache/solr/client/solrj/response/SpellCheckResponse.java
        208:    @Deprecated
        214:    @Deprecated
        
        solrj/src/java/org/apache/solr/client/solrj/SolrQuery.java
        449:  @Deprecated
        470:  @Deprecated
        492:  @Deprecated
        579:  @Deprecated
        591:  @Deprecated
        601:  @Deprecated
        618:  @Deprecated
        977:  @Deprecated
        985:  @Deprecated
        
        solrj/src/java/org/apache/solr/client/solrj/util/ClientUtils.java
        192:  @Deprecated
        201:  @Deprecated
        213:  @Deprecated
        222:  @Deprecated
        
        solrj/src/java/org/apache/solr/common/cloud/ClosableThread.java
        23:@Deprecated
        
        solrj/src/java/org/apache/solr/common/cloud/ClusterState.java
        56:  @Deprecated
        
        solrj/src/java/org/apache/solr/common/cloud/ImplicitDocRouter.java
        35://  @Deprecated
        
        solrj/src/java/org/apache/solr/common/params/AppendedSolrParams.java
        30:  @Deprecated
        
        solrj/src/java/org/apache/solr/common/params/DefaultSolrParams.java
        34:  @Deprecated
        
        solrj/src/java/org/apache/solr/common/params/FacetParams.java
        315:  @Deprecated
        
        solrj/src/java/org/apache/solr/common/params/ShardParams.java
        50:  @Deprecated
        
        solrj/src/java/org/apache/solr/common/util/NamedList.java
        120:  @Deprecated
        135:  @Deprecated
        
        solrj/src/java/org/apache/solr/common/util/SimpleOrderedMap.java
        52:  @Deprecated
        
        test-framework/src/java/org/apache/solr/SolrTestCaseJ4.java
        1030:  @Deprecated()
        
        Show
        Alan Woodward added a comment - solr git:(lucene_solr_4_10) $ ack --java '@Deprecated' contrib/clustering/src/java/org/apache/solr/handler/clustering/carrot2/CarrotParams.java 53: @Deprecated contrib/dataimporthandler/src/java/org/apache/solr/handler/dataimport/CachedSqlEntityProcessor.java 34:@Deprecated contrib/dataimporthandler/src/java/org/apache/solr/handler/dataimport/config/ConfigNameConstants.java 37: @Deprecated contrib/dataimporthandler/src/java/org/apache/solr/handler/dataimport/HttpDataSource.java 36:@Deprecated contrib/map-reduce/src/test/org/apache/solr/hadoop/hack/MiniMRCluster.java 50:@Deprecated core/src/java/org/apache/solr/analysis/LegacyHTMLStripCharFilter.java 49:@Deprecated core/src/java/org/apache/solr/analysis/LegacyHTMLStripCharFilterFactory.java 55:@Deprecated core/src/java/org/apache/solr/analysis/SolrAnalyzer.java 41: @Deprecated core/src/java/org/apache/solr/client/solrj/embedded/EmbeddedSolrServer.java 67: @Deprecated 238: @Deprecated core/src/java/org/apache/solr/cloud/OverseerCollectionProcessor.java 108: // @Deprecated- see on ZkStateReader 111: // @Deprecated- see on ZkStateReader core/src/java/org/apache/solr/common/ResourceLoader.java 24:@Deprecated core/src/java/org/apache/solr/core/CoreContainer.java 803: @Deprecated core/src/java/org/apache/solr/core/SolrConfig.java 384: @Deprecated 386: @Deprecated core/src/java/org/apache/solr/handler/admin/CoreAdminHandler.java 658: @Deprecated core/src/java/org/apache/solr/handler/BinaryUpdateRequestHandler.java 30:@Deprecated core/src/java/org/apache/solr/handler/CSVRequestHandler.java 25:@Deprecated core/src/java/org/apache/solr/handler/JsonUpdateRequestHandler.java 25:@Deprecated core/src/java/org/apache/solr/handler/MoreLikeThisHandler.java 387: @Deprecated core/src/java/org/apache/solr/handler/XmlUpdateRequestHandler.java 27:@Deprecated core/src/java/org/apache/solr/handler/XsltUpdateRequestHandler.java 27:@Deprecated core/src/java/org/apache/solr/highlight/DefaultSolrHighlighter.java 146: @Deprecated core/src/java/org/apache/solr/highlight/SolrHighlighter.java 41: @Deprecated core/src/java/org/apache/solr/parser/CharStream.java 30: @Deprecated 38: @Deprecated core/src/java/org/apache/solr/request/SimpleFacets.java 999: @Deprecated 1018: @Deprecated 1394: @Deprecated core/src/java/org/apache/solr/ rest /schema/analysis/FSTSynonymFilterFactory.java 53:@Deprecated core/src/java/org/apache/solr/schema/BCDIntField.java 31:@Deprecated core/src/java/org/apache/solr/schema/BCDLongField.java 24:@Deprecated core/src/java/org/apache/solr/schema/BCDStrField.java 24:@Deprecated core/src/java/org/apache/solr/schema/ByteField.java 50:@Deprecated core/src/java/org/apache/solr/schema/DateField.java 113:@Deprecated 272: @Deprecated core/src/java/org/apache/solr/schema/DoubleField.java 46:@Deprecated core/src/java/org/apache/solr/schema/FieldType.java 496: @Deprecated 545: @Deprecated core/src/java/org/apache/solr/schema/FloatField.java 45:@Deprecated core/src/java/org/apache/solr/schema/IndexSchema.java 278: @Deprecated core/src/java/org/apache/solr/schema/IntField.java 45:@Deprecated core/src/java/org/apache/solr/schema/LongField.java 45:@Deprecated core/src/java/org/apache/solr/schema/SchemaField.java 100: @Deprecated core/src/java/org/apache/solr/schema/ShortField.java 51:@Deprecated core/src/java/org/apache/solr/schema/SortableDoubleField.java 55:@Deprecated 128:@Deprecated core/src/java/org/apache/solr/schema/SortableFloatField.java 56:@Deprecated 130:@Deprecated core/src/java/org/apache/solr/schema/SortableIntField.java 56:@Deprecated 133:@Deprecated core/src/java/org/apache/solr/schema/SortableLongField.java 55:@Deprecated 129:@Deprecated core/src/java/org/apache/solr/schema/TrieField.java 358: @Deprecated 363: @Deprecated core/src/java/org/apache/solr/search/QueryParsing.java 230: @Deprecated core/src/java/org/apache/solr/search/SortSpec.java 48: @Deprecated 54: @Deprecated 62: @Deprecated core/src/java/org/apache/solr/update/processor/FieldMutatingUpdateProcessorFactory.java 254: @Deprecated 294: @Deprecated core/src/java/org/apache/solr/update/SolrIndexConfig.java 55: @Deprecated core/src/java/org/apache/solr/util/BCDUtils.java 24:@Deprecated core/src/java/org/apache/solr/util/plugin/ResourceLoaderAware.java 24:@Deprecated core/src/test/org/apache/solr/core/ResourceLoaderTest.java 219: @Deprecated solrj/src/java/org/apache/solr/client/solrj/request/CoreAdminRequest.java 590: @Deprecated solrj/src/java/org/apache/solr/client/solrj/response/RangeFacet.java 87: @Deprecated 100: @Deprecated solrj/src/java/org/apache/solr/client/solrj/response/SpellCheckResponse.java 208: @Deprecated 214: @Deprecated solrj/src/java/org/apache/solr/client/solrj/SolrQuery.java 449: @Deprecated 470: @Deprecated 492: @Deprecated 579: @Deprecated 591: @Deprecated 601: @Deprecated 618: @Deprecated 977: @Deprecated 985: @Deprecated solrj/src/java/org/apache/solr/client/solrj/util/ClientUtils.java 192: @Deprecated 201: @Deprecated 213: @Deprecated 222: @Deprecated solrj/src/java/org/apache/solr/common/cloud/ClosableThread.java 23:@Deprecated solrj/src/java/org/apache/solr/common/cloud/ClusterState.java 56: @Deprecated solrj/src/java/org/apache/solr/common/cloud/ImplicitDocRouter.java 35: // @Deprecated solrj/src/java/org/apache/solr/common/params/AppendedSolrParams.java 30: @Deprecated solrj/src/java/org/apache/solr/common/params/DefaultSolrParams.java 34: @Deprecated solrj/src/java/org/apache/solr/common/params/FacetParams.java 315: @Deprecated solrj/src/java/org/apache/solr/common/params/ShardParams.java 50: @Deprecated solrj/src/java/org/apache/solr/common/util/NamedList.java 120: @Deprecated 135: @Deprecated solrj/src/java/org/apache/solr/common/util/SimpleOrderedMap.java 52: @Deprecated test-framework/src/java/org/apache/solr/SolrTestCaseJ4.java 1030: @Deprecated()
        Hide
        Alan Woodward added a comment -

        Each one will need an entry in MIGRATE.txt explaining what to use instead. I'll get to this later in the week, but if anybody wants to start knocking them off beforehand, feel free. Meanwhile, I'll get back to shouting in frustration at ShardSplitTest.

        Show
        Alan Woodward added a comment - Each one will need an entry in MIGRATE.txt explaining what to use instead. I'll get to this later in the week, but if anybody wants to start knocking them off beforehand, feel free. Meanwhile, I'll get back to shouting in frustration at ShardSplitTest.
        Hide
        Shawn Heisey added a comment -

        I was looking at this recently myself, wondering if we had gotten all the deprecated code removed. It looked like we hadn't.

        Is there a corresponding issue for Lucene too? I think it may have the same problem.

        Show
        Shawn Heisey added a comment - I was looking at this recently myself, wondering if we had gotten all the deprecated code removed. It looked like we hadn't. Is there a corresponding issue for Lucene too? I think it may have the same problem.
        Hide
        Alan Woodward added a comment -

        I've removed (or, in some cases, undeprecated) everything I feel comfortable with, but there are a few bits here that I don't know enough about to deal with:

        • SimpleFacets.rangeCount() - this seems to be used elsewhere in places that it doesn't obviously make sense to use the suggested replacement classes.
        • MiniMRCluster - presumably should be replaced by MiniMrClientCluster from an external lib, but it's not obvious how
        • ImplicitDocRouter and ShardParams.SHARD_KEYS - these have comments about how they should be removed 'later', but it's not clear if these still need to be supported.
        • NamedList and SimpleOrderedMap constructors - the deprecation comments suggest that there's still more work that needs to be done here before the deprecated constructors can be removed.
        Show
        Alan Woodward added a comment - I've removed (or, in some cases, undeprecated) everything I feel comfortable with, but there are a few bits here that I don't know enough about to deal with: SimpleFacets.rangeCount() - this seems to be used elsewhere in places that it doesn't obviously make sense to use the suggested replacement classes. MiniMRCluster - presumably should be replaced by MiniMrClientCluster from an external lib, but it's not obvious how ImplicitDocRouter and ShardParams.SHARD_KEYS - these have comments about how they should be removed 'later', but it's not clear if these still need to be supported. NamedList and SimpleOrderedMap constructors - the deprecation comments suggest that there's still more work that needs to be done here before the deprecated constructors can be removed.
        Hide
        Alan Woodward added a comment -

        Chris Hostetter (Unused) can you give me any suggestions on SimpleFacets.rangeCount()?
        Noble Paul similarly for ImplicitDocRouter and ShardParams.SHARD_KEYS?

        The NamedList and SimpleOrderedMap deprecated constructors have been there so long that git blame doesn't tell me who deprecated them in the first place, so I think we should just undeprecate these.

        MiniMRCluster is only in the test framework, so I don't think that matters so much.

        Show
        Alan Woodward added a comment - Chris Hostetter (Unused) can you give me any suggestions on SimpleFacets.rangeCount()? Noble Paul similarly for ImplicitDocRouter and ShardParams.SHARD_KEYS? The NamedList and SimpleOrderedMap deprecated constructors have been there so long that git blame doesn't tell me who deprecated them in the first place, so I think we should just undeprecate these. MiniMRCluster is only in the test framework, so I don't think that matters so much.
        Hide
        Noble Paul added a comment -

        ShardParams.SHARD_KEYS is deprecated in favor of ShardParams._ROUTE_

        We can remove that

        Show
        Noble Paul added a comment - ShardParams.SHARD_KEYS is deprecated in favor of ShardParams._ROUTE_ We can remove that
        Hide
        Alan Woodward added a comment - - edited

        I've removed ShardParams.SHARD_KEYS, and replaced it with _ROUTE_ in the appropriate places, but it's causing ShardRoutingTest to fail. Noble Paul could you have a look?

        Show
        Alan Woodward added a comment - - edited I've removed ShardParams.SHARD_KEYS, and replaced it with _ROUTE_ in the appropriate places, but it's causing ShardRoutingTest to fail. Noble Paul could you have a look?
        Hide
        Noble Paul added a comment -

        please apply this on top of your patch Alan Woodward

        Show
        Noble Paul added a comment - please apply this on top of your patch Alan Woodward
        Hide
        Hoss Man added a comment -

        SimpleFacets.rangeCount() - this seems to be used elsewhere in places that it doesn't obviously make sense to use the suggested replacement classes.

        There are 2 rangeCount methods, the one that is deprecated is...

          /**
           * @deprecated Use rangeCount(SchemaField,String,String,boolean,boolean) which is more generalized
           */
          @Deprecated
          protected int rangeCount(SchemaField sf, Date low, Date high,
                                   boolean iLow, boolean iHigh) throws IOException {
        

        ...the only place that version of rangeCount is used is inside of SimpleFacets.getFacetDateCounts – which is also deprecated.

        removing SimpleFacets.getFacetDateCounts is a bigger undertaking, because it conceptually means removing all of the "facet.date" functionality (not just internal APIs)

        I'm -0 on making the call to (finally) remove all end user support for facet.date this late in the process for 5.0, but what would probably make sense is to go ahead and rename & make private the deprecated rangeCount method.

        Show
        Hoss Man added a comment - SimpleFacets.rangeCount() - this seems to be used elsewhere in places that it doesn't obviously make sense to use the suggested replacement classes. There are 2 rangeCount methods, the one that is deprecated is... /** * @deprecated Use rangeCount(SchemaField, String , String , boolean , boolean ) which is more generalized */ @Deprecated protected int rangeCount(SchemaField sf, Date low, Date high, boolean iLow, boolean iHigh) throws IOException { ...the only place that version of rangeCount is used is inside of SimpleFacets.getFacetDateCounts – which is also deprecated. removing SimpleFacets.getFacetDateCounts is a bigger undertaking, because it conceptually means removing all of the "facet.date" functionality (not just internal APIs) I'm -0 on making the call to (finally) remove all end user support for facet.date this late in the process for 5.0, but what would probably make sense is to go ahead and rename & make private the deprecated rangeCount method.
        Hide
        Alan Woodward added a comment -

        Thanks Noble, that's fixed it.

        Hoss, is there a clear replacement for facet.date? I worry that if we carry it over to 5.0 then we'll just run through the same process at the last minute before a 6.0 release, and it ends up being supported in perpetuity.

        Show
        Alan Woodward added a comment - Thanks Noble, that's fixed it. Hoss, is there a clear replacement for facet.date? I worry that if we carry it over to 5.0 then we'll just run through the same process at the last minute before a 6.0 release, and it ends up being supported in perpetuity.
        Hide
        Hoss Man added a comment -

        Hoss, is there a clear replacement for facet.date? ...

        facet.date was superceeded by facet.range in SOLR-1240 - the internal methods were deprecated (so new internal code would be discouraged from using it) but we've always continued to support the functionality at the HTTP layer...

        Aparently the SolrJ "FacetParams" associated with date faceting were never actually marked "deprecated", so that's another factor to the equation: https://lucene.apache.org/solr/4_10_1/solr-solrj/org/apache/solr/common/params/FacetParams.html#FACET_DATE

        NOTE however: the SolrQuery faceting convinience methods – ie: addDateRangeFacet – have aparently always used facet.range. that feature deprecation evidently preceeded the creation of those solrj methods: https://svn.apache.org/r1150361 ... so the odds of any SolrJ clients actaully using facet.date are pretty low – but that doesn't say anything about people using solr from other clients or rolling their own requests

        i have no opinion about removing the facet.date functionality from 5.0 - people shouldn't still be using it, but if we remove it and they are the inconvenience is painful: it will manifest either as client errors or silently returning no facet results (when the client tries to parse response data that isn't there) while the only benefit is less code on our end ... which is always nice, but hard to gauge on the value tradeoff – i defer judgement.

        (unless of course: you want to add some logic to FacetComponent that returns a hard fail if "facet.date" is a specified param ... that might be a better error condition for client then just ripping the functionality out)

        Show
        Hoss Man added a comment - Hoss, is there a clear replacement for facet.date? ... facet.date was superceeded by facet.range in SOLR-1240 - the internal methods were deprecated (so new internal code would be discouraged from using it) but we've always continued to support the functionality at the HTTP layer... Aparently the SolrJ "FacetParams" associated with date faceting were never actually marked "deprecated", so that's another factor to the equation: https://lucene.apache.org/solr/4_10_1/solr-solrj/org/apache/solr/common/params/FacetParams.html#FACET_DATE NOTE however: the SolrQuery faceting convinience methods – ie: addDateRangeFacet – have aparently always used facet.range. that feature deprecation evidently preceeded the creation of those solrj methods: https://svn.apache.org/r1150361 ... so the odds of any SolrJ clients actaully using facet.date are pretty low – but that doesn't say anything about people using solr from other clients or rolling their own requests — i have no opinion about removing the facet.date functionality from 5.0 - people shouldn't still be using it, but if we remove it and they are the inconvenience is painful: it will manifest either as client errors or silently returning no facet results (when the client tries to parse response data that isn't there) while the only benefit is less code on our end ... which is always nice, but hard to gauge on the value tradeoff – i defer judgement. (unless of course: you want to add some logic to FacetComponent that returns a hard fail if "facet.date" is a specified param ... that might be a better error condition for client then just ripping the functionality out)
        Hide
        Alan Woodward added a comment -

        OK, I think the thing to do here is to deprecate FacetParams.FACET_DATE, and add a bit of logic that adds a warning to any request that includes it saying "this is deprecated, use facet.range instead". And then remove it from trunk.

        I think this deserves its own separate issue.

        Show
        Alan Woodward added a comment - OK, I think the thing to do here is to deprecate FacetParams.FACET_DATE, and add a bit of logic that adds a warning to any request that includes it saying "this is deprecated, use facet.range instead". And then remove it from trunk. I think this deserves its own separate issue.
        Hide
        Alan Woodward added a comment -

        See SOLR-7010. No need for this to get into 5.0 though.

        Show
        Alan Woodward added a comment - See SOLR-7010 . No need for this to get into 5.0 though.
        Hide
        Alan Woodward added a comment -

        I'm going to undeprecate the dataimporthandler long form variable-resolver namespace, as I don't think it hurts us to support it, and removing it causes test failures that are completely inexplicable until you realise that resolution silently fails to execute properly. If this really needs to be deprecated, then variable resolution should be updated to throw an error when it encounters an unrecognised namespace.

        Show
        Alan Woodward added a comment - I'm going to undeprecate the dataimporthandler long form variable-resolver namespace, as I don't think it hurts us to support it, and removing it causes test failures that are completely inexplicable until you realise that resolution silently fails to execute properly. If this really needs to be deprecated, then variable resolution should be updated to throw an error when it encounters an unrecognised namespace.
        Hide
        Alan Woodward added a comment -

        Final patch, committing shortly.

        Show
        Alan Woodward added a comment - Final patch, committing shortly.
        Hide
        ASF subversion and git services added a comment -

        Commit 1653549 from Alan Woodward in branch 'dev/trunk'
        [ https://svn.apache.org/r1653549 ]

        SOLR-6976: Remove methods and classes deprecated in 4.x

        Show
        ASF subversion and git services added a comment - Commit 1653549 from Alan Woodward in branch 'dev/trunk' [ https://svn.apache.org/r1653549 ] SOLR-6976 : Remove methods and classes deprecated in 4.x
        Hide
        ASF subversion and git services added a comment -

        Commit 1653555 from Alan Woodward in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1653555 ]

        SOLR-6976: Remove methods and classes deprecated in 4.x

        Show
        ASF subversion and git services added a comment - Commit 1653555 from Alan Woodward in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1653555 ] SOLR-6976 : Remove methods and classes deprecated in 4.x
        Hide
        ASF subversion and git services added a comment -

        Commit 1653566 from Alan Woodward in branch 'dev/branches/lucene_solr_5_0'
        [ https://svn.apache.org/r1653566 ]

        SOLR-6976: Remove methods and classes deprecated in 4.x

        Show
        ASF subversion and git services added a comment - Commit 1653566 from Alan Woodward in branch 'dev/branches/lucene_solr_5_0' [ https://svn.apache.org/r1653566 ] SOLR-6976 : Remove methods and classes deprecated in 4.x
        Hide
        Anshum Gupta added a comment -

        Bulk close after 5.0 release.

        Show
        Anshum Gupta added a comment - Bulk close after 5.0 release.

          People

          • Assignee:
            Alan Woodward
            Reporter:
            Alan Woodward
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development