Solr
  1. Solr
  2. SOLR-6904

Remove deprecated Circle/Rect format from trunk & 5.0

    Details

    • Type: Task Task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.0, 6.0
    • Component/s: spatial
    • Labels:
      None

      Description

      The Solr 4 spatial code introduced a custom format for a rectangle and a Circle. In 4.3, it was deprecated in favor of WKT, which no longer required JTS for WKT parsing. It should be removed now. The syntax is governed by LegacyShapeReadWriterFormat (Spatial4j) referenced by Solr's AbstractSpatialFieldType.parseShape.

      Examples of the syntax to be removed are as follows:

      • Rect: -74.093 41.042 -69.347 44.558
      • Circle: Circle(4.56,1.23 d=0.0710)

      In addition to use in indexing & querying, the rect shape is also found in the worldBounds attribute (optional, only required if you use geo=false)

        Activity

        Hide
        David Smiley added a comment -

        Here's a patch. I'll commit this Tuesday.

        Show
        David Smiley added a comment - Here's a patch. I'll commit this Tuesday.
        Hide
        David Smiley added a comment -

        Updated patch with one that works

        Show
        David Smiley added a comment - Updated patch with one that works
        Hide
        ASF subversion and git services added a comment -

        Commit 1651351 from David Smiley in branch 'dev/trunk'
        [ https://svn.apache.org/r1651351 ]

        SOLR-6904: remove deprecated spatial Circle & Rect syntax
        FYI these weren't used often and were replaced with supported syntaxes in v4.3.

        Show
        ASF subversion and git services added a comment - Commit 1651351 from David Smiley in branch 'dev/trunk' [ https://svn.apache.org/r1651351 ] SOLR-6904 : remove deprecated spatial Circle & Rect syntax FYI these weren't used often and were replaced with supported syntaxes in v4.3.
        Hide
        ASF subversion and git services added a comment -

        Commit 1651357 from David Smiley in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1651357 ]

        SOLR-6904: remove deprecated spatial Circle & Rect syntax
        FYI these weren't used often and were replaced with supported syntaxes in v4.3.

        Show
        ASF subversion and git services added a comment - Commit 1651357 from David Smiley in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1651357 ] SOLR-6904 : remove deprecated spatial Circle & Rect syntax FYI these weren't used often and were replaced with supported syntaxes in v4.3.
        Hide
        Anshum Gupta added a comment -

        Bulk close after 5.0 release.

        Show
        Anshum Gupta added a comment - Bulk close after 5.0 release.

          People

          • Assignee:
            David Smiley
            Reporter:
            David Smiley
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development