Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-6902

Use JUnit rules instead of inheritance with distributed Solr tests to allow for multiple tests without the same class

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.1, 6.0
    • Component/s: Tests
    • Labels:
      None

      Description

      Finally got annoyed enough with too many things being clubbed into one test method in all distributed Solr tests (anything inheriting from BaseDistributedSearchTestCase and currently implementing doTest)..

      This just lays the groundwork really for allowing multiple test methods within the same class, and doesn't split tests as yet or flatten the inheritance hierarchy (when abused for doing multiple tests), as this touches a lot of files by itself. For that reason, the sooner this is picked up the better..

        Attachments

        1. SOLR-6902.patch
          174 kB
          Erick Erickson
        2. SOLR-6902.patch
          173 kB
          Erick Erickson
        3. SOLR-6902.patch
          170 kB
          Ramkumar Aiyengar
        4. SOLR-6902.patch
          175 kB
          Erick Erickson
        5. SOLR-6902.patch
          190 kB
          Ramkumar Aiyengar

          Issue Links

            Activity

              People

              • Assignee:
                erickerickson Erick Erickson
                Reporter:
                andyetitmoves Ramkumar Aiyengar
              • Votes:
                0 Vote for this issue
                Watchers:
                10 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: