Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-6899

SolrJ CollectionAdminRequest classes should not support public setters for action

Agile BoardAttach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 5.0, 6.0
    • clients - java, SolrJ
    • None

    Description

      There shouldn't be public action setters for the CollectionAdminRequests.

      To elaborate more, a Create object should be able to do just that, doesn't make sense to support/have the following:

      Create c = new Create();
      c.setAction("RELOAD");
      

      The implementation could have an action = <custom action> in case of custom actions.

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            anshum Anshum Gupta
            anshum Anshum Gupta
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment