Solr
  1. Solr
  2. SOLR-6899

SolrJ CollectionAdminRequest classes should not support public setters for action

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.0, 6.0
    • Component/s: clients - java, SolrJ
    • Labels:
      None

      Description

      There shouldn't be public action setters for the CollectionAdminRequests.

      To elaborate more, a Create object should be able to do just that, doesn't make sense to support/have the following:

      Create c = new Create();
      c.setAction("RELOAD");
      

      The implementation could have an action = <custom action> in case of custom actions.

      1. SOLR-6899.patch
        0.6 kB
        Anshum Gupta

        Activity

        Hide
        Anshum Gupta added a comment -

        Changed the description for this change to be just limited to 'action' as CollectionAdminRequest extends SolrRequest which has public path/method methods.

        Show
        Anshum Gupta added a comment - Changed the description for this change to be just limited to 'action' as CollectionAdminRequest extends SolrRequest which has public path/method methods.
        Hide
        Anshum Gupta added a comment -

        Small patch that fixes this.

        Show
        Anshum Gupta added a comment - Small patch that fixes this.
        Hide
        ASF subversion and git services added a comment -

        Commit 1648451 from Anshum Gupta in branch 'dev/trunk'
        [ https://svn.apache.org/r1648451 ]

        SOLR-6899: Make CollectionAdminRequest.action setter protected instead of public

        Show
        ASF subversion and git services added a comment - Commit 1648451 from Anshum Gupta in branch 'dev/trunk' [ https://svn.apache.org/r1648451 ] SOLR-6899 : Make CollectionAdminRequest.action setter protected instead of public
        Hide
        ASF subversion and git services added a comment -

        Commit 1648452 from Anshum Gupta in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1648452 ]

        SOLR-6899: Make CollectionAdminRequest.action setter protected instead of public (merge from trunk)

        Show
        ASF subversion and git services added a comment - Commit 1648452 from Anshum Gupta in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1648452 ] SOLR-6899 : Make CollectionAdminRequest.action setter protected instead of public (merge from trunk)
        Hide
        Anshum Gupta added a comment -

        Bulk close after 5.0 release.

        Show
        Anshum Gupta added a comment - Bulk close after 5.0 release.

          People

          • Assignee:
            Anshum Gupta
            Reporter:
            Anshum Gupta
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development