Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-6899

SolrJ CollectionAdminRequest classes should not support public setters for action

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.0, 6.0
    • Component/s: clients - java, SolrJ
    • Labels:
      None

      Description

      There shouldn't be public action setters for the CollectionAdminRequests.

      To elaborate more, a Create object should be able to do just that, doesn't make sense to support/have the following:

      Create c = new Create();
      c.setAction("RELOAD");
      

      The implementation could have an action = <custom action> in case of custom actions.

        Attachments

        1. SOLR-6899.patch
          0.6 kB
          Anshum Gupta

          Activity

            People

            • Assignee:
              anshumg Anshum Gupta
              Reporter:
              anshumg Anshum Gupta
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: