Details

    • Type: Wish Wish
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.2, 6.0
    • Component/s: None
    • Labels:
      None

      Description

      There's a size>0 check which seems to be redundant and some DelegatingCollector.finish calls seem to be missing.

      1. SOLR-6886.patch
        0.9 kB
        Shalin Shekhar Mangar
      2. SOLR-6886.patch
        1 kB
        Shalin Shekhar Mangar

        Activity

        Hide
        ASF GitHub Bot added a comment -

        GitHub user cpoerschke opened a pull request:

        https://github.com/apache/lucene-solr/pull/116

        SOLR-6886: Grouping.java tweaks

        for https://issues.apache.org/jira/i#browse/SOLR-6886 ticket

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/bloomberg/lucene-solr trunk-Grouping-tweaks

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/lucene-solr/pull/116.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #116


        commit 5361b06bd1eb7389566f8604a21d433d748d6590
        Author: Christine Poerschke <cpoerschke@bloomberg.net>
        Date: 2014-11-18T15:27:06Z

        solr: Grouping.java tweaks

        remove redundant size>0 check, add missing DelegatingCollector.finish calls


        Show
        ASF GitHub Bot added a comment - GitHub user cpoerschke opened a pull request: https://github.com/apache/lucene-solr/pull/116 SOLR-6886 : Grouping.java tweaks for https://issues.apache.org/jira/i#browse/SOLR-6886 ticket You can merge this pull request into a Git repository by running: $ git pull https://github.com/bloomberg/lucene-solr trunk-Grouping-tweaks Alternatively you can review and apply these changes as the patch at: https://github.com/apache/lucene-solr/pull/116.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #116 commit 5361b06bd1eb7389566f8604a21d433d748d6590 Author: Christine Poerschke <cpoerschke@bloomberg.net> Date: 2014-11-18T15:27:06Z solr: Grouping.java tweaks remove redundant size>0 check, add missing DelegatingCollector.finish calls
        Hide
        Shalin Shekhar Mangar added a comment -

        Patch in sync with trunk. There was another place where the finish method was not being called so I fixed that too.

        Show
        Shalin Shekhar Mangar added a comment - Patch in sync with trunk. There was another place where the finish method was not being called so I fixed that too.
        Hide
        Shalin Shekhar Mangar added a comment -

        Refactored to call finish in one place regardless of the branch executed. I'll commit this shortly.

        Show
        Shalin Shekhar Mangar added a comment - Refactored to call finish in one place regardless of the branch executed. I'll commit this shortly.
        Hide
        ASF subversion and git services added a comment -

        Commit 1674430 from shalin@apache.org in branch 'dev/trunk'
        [ https://svn.apache.org/r1674430 ]

        SOLR-6886: Removed redundant size check and added missing calls to DelegatingCollection.finish inside Grouping code

        Show
        ASF subversion and git services added a comment - Commit 1674430 from shalin@apache.org in branch 'dev/trunk' [ https://svn.apache.org/r1674430 ] SOLR-6886 : Removed redundant size check and added missing calls to DelegatingCollection.finish inside Grouping code
        Hide
        ASF subversion and git services added a comment -

        Commit 1674431 from shalin@apache.org in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1674431 ]

        SOLR-6886: Removed redundant size check and added missing calls to DelegatingCollection.finish inside Grouping code. This closes #116.

        Show
        ASF subversion and git services added a comment - Commit 1674431 from shalin@apache.org in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1674431 ] SOLR-6886 : Removed redundant size check and added missing calls to DelegatingCollection.finish inside Grouping code. This closes #116.
        Hide
        Shalin Shekhar Mangar added a comment -

        Thanks Christine!

        Show
        Shalin Shekhar Mangar added a comment - Thanks Christine!
        Hide
        Anshum Gupta added a comment -

        Bulk close for 5.2.0.

        Show
        Anshum Gupta added a comment - Bulk close for 5.2.0.
        Hide
        ASF GitHub Bot added a comment -

        Github user cpoerschke closed the pull request at:

        https://github.com/apache/lucene-solr/pull/116

        Show
        ASF GitHub Bot added a comment - Github user cpoerschke closed the pull request at: https://github.com/apache/lucene-solr/pull/116

          People

          • Assignee:
            Shalin Shekhar Mangar
            Reporter:
            Christine Poerschke
          • Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development