Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.0, 6.0
    • Component/s: None
    • Labels:
      None

      Description

      To make log inspection and debugging easier.

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user cpoerschke opened a pull request:

        https://github.com/apache/lucene-solr/pull/115

        SOLR-6885: tweak some thread names

        For https://issues.apache.org/jira/i#browse/SOLR-6885 ticket.

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/bloomberg/lucene-solr branch_4x-thread-name-tweaks

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/lucene-solr/pull/115.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #115


        commit 6e55212b1bbc52f84cbd4d364d31c3de478c661e
        Author: Christine Poerschke <cpoerschke@bloomberg.net>
        Date: 2014-12-11T10:30:03Z

        solr: tweak some thread names

        Append core name to RecoveryThread. Name the onReconnect thread as such, with timestamp suffix for chronological ordering.


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user cpoerschke opened a pull request: https://github.com/apache/lucene-solr/pull/115 SOLR-6885 : tweak some thread names For https://issues.apache.org/jira/i#browse/SOLR-6885 ticket. You can merge this pull request into a Git repository by running: $ git pull https://github.com/bloomberg/lucene-solr branch_4x-thread-name-tweaks Alternatively you can review and apply these changes as the patch at: https://github.com/apache/lucene-solr/pull/115.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #115 commit 6e55212b1bbc52f84cbd4d364d31c3de478c661e Author: Christine Poerschke <cpoerschke@bloomberg.net> Date: 2014-12-11T10:30:03Z solr: tweak some thread names Append core name to RecoveryThread. Name the onReconnect thread as such, with timestamp suffix for chronological ordering.
        Hide
        shalinmangar Shalin Shekhar Mangar added a comment -

        Hi Christine Poerschke, there is no onReconnect thread in ConnectionManager in Solr trunk so the patch doesn't apply.

        Show
        shalinmangar Shalin Shekhar Mangar added a comment - Hi Christine Poerschke , there is no onReconnect thread in ConnectionManager in Solr trunk so the patch doesn't apply.
        Hide
        cpoerschke Christine Poerschke added a comment -

        Hi Shalin Shekhar Mangar, yes, sorry, i should have been clearer re: why/that it's a branch_4x patch. The onReconnect thread in ConnectionManager in branch_4x is from SOLR-5615 changes, SOLR-5615 also mentions a Solr trunk commit (https://svn.apache.org/r1556572) and a quick inspection shows the onReconnect thread being added in that commit. Let me check further re: why the onReconnect thread is now no longer present in Solr trunk ConnectionManager.

        Show
        cpoerschke Christine Poerschke added a comment - Hi Shalin Shekhar Mangar , yes, sorry, i should have been clearer re: why/that it's a branch_4x patch. The onReconnect thread in ConnectionManager in branch_4x is from SOLR-5615 changes, SOLR-5615 also mentions a Solr trunk commit ( https://svn.apache.org/r1556572 ) and a quick inspection shows the onReconnect thread being added in that commit. Let me check further re: why the onReconnect thread is now no longer present in Solr trunk ConnectionManager.
        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user cpoerschke opened a pull request:

        https://github.com/apache/lucene-solr/pull/117

        SOLR-6885: Append core name to RecoveryThread thread name.

        for https://issues.apache.org/jira/i#browse/SOLR-6885 ticket

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/bloomberg/lucene-solr trunk-thread-name-tweaks

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/lucene-solr/pull/117.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #117


        commit 98bb50752679ceeffd3b6dce319837bf1e0f1a63
        Author: Christine Poerschke <cpoerschke@bloomberg.net>
        Date: 2014-12-11T10:30:03Z

        SOLR-6885: Append core name to RecoveryThread thread name.


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user cpoerschke opened a pull request: https://github.com/apache/lucene-solr/pull/117 SOLR-6885 : Append core name to RecoveryThread thread name. for https://issues.apache.org/jira/i#browse/SOLR-6885 ticket You can merge this pull request into a Git repository by running: $ git pull https://github.com/bloomberg/lucene-solr trunk-thread-name-tweaks Alternatively you can review and apply these changes as the patch at: https://github.com/apache/lucene-solr/pull/117.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #117 commit 98bb50752679ceeffd3b6dce319837bf1e0f1a63 Author: Christine Poerschke <cpoerschke@bloomberg.net> Date: 2014-12-11T10:30:03Z SOLR-6885 : Append core name to RecoveryThread thread name.
        Hide
        cpoerschke Christine Poerschke added a comment -

        Latest pull request above is for Solr trunk, SOLR-6570 commit https://svn.apache.org/r1640566 removed the onReconnect thread from Solr trunk, SOLR-6570 also has a branch_5x commit but no branch_4x commit, hence the onReconnect thread name tweak would only apply to branch_4x. Apologies for the confusion.

        Show
        cpoerschke Christine Poerschke added a comment - Latest pull request above is for Solr trunk, SOLR-6570 commit https://svn.apache.org/r1640566 removed the onReconnect thread from Solr trunk, SOLR-6570 also has a branch_5x commit but no branch_4x commit, hence the onReconnect thread name tweak would only apply to branch_4x. Apologies for the confusion.
        Hide
        shalinmangar Shalin Shekhar Mangar added a comment -

        Sounds good but I'd like to have RecoveryThread use coreNodeName instead of core name to aid in debugging where all cores are named the same e.g. collection1. What do you think?

        Show
        shalinmangar Shalin Shekhar Mangar added a comment - Sounds good but I'd like to have RecoveryThread use coreNodeName instead of core name to aid in debugging where all cores are named the same e.g. collection1. What do you think?
        Hide
        cpoerschke Christine Poerschke added a comment -

        Interesting scenario, all cores being named the same. How about using both coreName and coreNodeName? That will make the thread name longer (RecoveryThread-collection1_shard1_replica1-core_node1 or RecoveryThread-collection1-core_node1) but having the shard1 element of the coreName visible is useful i think.

        Show
        cpoerschke Christine Poerschke added a comment - Interesting scenario, all cores being named the same. How about using both coreName and coreNodeName? That will make the thread name longer (RecoveryThread-collection1_shard1_replica1-core_node1 or RecoveryThread-collection1-core_node1) but having the shard1 element of the coreName visible is useful i think.
        Hide
        shalinmangar Shalin Shekhar Mangar added a comment -

        No, let it be. Let's go with core name because the scenario I describe applied to Solr's tests only and we should find another way to solve that. I'll commit your patch as-is.

        Show
        shalinmangar Shalin Shekhar Mangar added a comment - No, let it be. Let's go with core name because the scenario I describe applied to Solr's tests only and we should find another way to solve that. I'll commit your patch as-is.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 1647799 from shalin@apache.org in branch 'dev/trunk'
        [ https://svn.apache.org/r1647799 ]

        SOLR-6885: Add core name to RecoveryThread name

        This closes #117.

        Show
        jira-bot ASF subversion and git services added a comment - Commit 1647799 from shalin@apache.org in branch 'dev/trunk' [ https://svn.apache.org/r1647799 ] SOLR-6885 : Add core name to RecoveryThread name This closes #117.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 1647801 from shalin@apache.org in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1647801 ]

        SOLR-6885: Add core name to RecoveryThread name

        Show
        jira-bot ASF subversion and git services added a comment - Commit 1647801 from shalin@apache.org in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1647801 ] SOLR-6885 : Add core name to RecoveryThread name
        Hide
        shalinmangar Shalin Shekhar Mangar added a comment -

        Thanks Christine!

        Show
        shalinmangar Shalin Shekhar Mangar added a comment - Thanks Christine!
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/lucene-solr/pull/117

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/lucene-solr/pull/117
        Hide
        anshumg Anshum Gupta added a comment -

        Bulk close after 5.0 release.

        Show
        anshumg Anshum Gupta added a comment - Bulk close after 5.0 release.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user cpoerschke closed the pull request at:

        https://github.com/apache/lucene-solr/pull/115

        Show
        githubbot ASF GitHub Bot added a comment - Github user cpoerschke closed the pull request at: https://github.com/apache/lucene-solr/pull/115

          People

          • Assignee:
            shalinmangar Shalin Shekhar Mangar
            Reporter:
            cpoerschke Christine Poerschke
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development