Solr
  1. Solr
  2. SOLR-6882

Misspelled collection API actions in ReplicaMutator exception messages

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 5.0, 6.0
    • Fix Version/s: 5.0, 6.0
    • Component/s: SolrCloud
    • Labels:
      None

      Description

      ReplicaMutator.java
       90:  public ZkWriteCommand addReplicaProperty(ClusterState clusterState, ZkNodeProps message) {
      [...]
       96:      throw new SolrException(SolrException.ErrorCode.BAD_REQUEST,
       97:          "Overseer SETREPLICAPROPERTY requires " +
       98:              ZkStateReader.COLLECTION_PROP + " and " + ZkStateReader.SHARD_ID_PROP + " and " +
       99:             ZkStateReader.REPLICA_PROP + " and " + ZkStateReader.PROPERTY_PROP + " and " +
      100:              ZkStateReader.PROPERTY_VALUE_PROP + " no action taken.");
      [...]
      118:        throw new SolrException(SolrException.ErrorCode.BAD_REQUEST, "Overseer SETREPLICAPROPERTY for " +
      119:            property + " cannot have " + OverseerCollectionProcessor.SHARD_UNIQUE + " set to anything other than" +
      120:            "'true'. No action taken");
      

        Activity

        Hide
        Steve Rowe added a comment - - edited

        Another misspelling, ReplicaMutator.removeReplicaProperty(): DELETEREPLICAPROP misspelled as DELETEREPLICAPROPERTY:

        ReplicaMutator.java
        156:  public ZkWriteCommand removeReplicaProperty(ClusterState clusterState, ZkNodeProps message) {
        [...]
        161:      throw new SolrException(SolrException.ErrorCode.BAD_REQUEST,
        162:          "Overseer DELETEREPLICAPROPERTY requires " +
        163:              ZkStateReader.COLLECTION_PROP + " and " + ZkStateReader.SHARD_ID_PROP + " and " +
        164:              ZkStateReader.REPLICA_PROP + " and " + ZkStateReader.PROPERTY_PROP + " no action taken.");
        
        Show
        Steve Rowe added a comment - - edited Another misspelling, ReplicaMutator.removeReplicaProperty() : DELETEREPLICAPROP misspelled as DELETEREPLICAPROPERTY : ReplicaMutator.java 156: public ZkWriteCommand removeReplicaProperty(ClusterState clusterState, ZkNodeProps message) { [...] 161: throw new SolrException(SolrException.ErrorCode.BAD_REQUEST, 162: "Overseer DELETEREPLICAPROPERTY requires " + 163: ZkStateReader.COLLECTION_PROP + " and " + ZkStateReader.SHARD_ID_PROP + " and " + 164: ZkStateReader.REPLICA_PROP + " and " + ZkStateReader.PROPERTY_PROP + " no action taken." );
        Hide
        ASF subversion and git services added a comment -

        Commit 1647553 from shalin@apache.org in branch 'dev/trunk'
        [ https://svn.apache.org/r1647553 ]

        SOLR-6882: Misspelled collection API actions in ReplicaMutator exception messages

        Show
        ASF subversion and git services added a comment - Commit 1647553 from shalin@apache.org in branch 'dev/trunk' [ https://svn.apache.org/r1647553 ] SOLR-6882 : Misspelled collection API actions in ReplicaMutator exception messages
        Hide
        ASF subversion and git services added a comment -

        Commit 1647555 from shalin@apache.org in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1647555 ]

        SOLR-6882: Misspelled collection API actions in ReplicaMutator exception messages

        Show
        ASF subversion and git services added a comment - Commit 1647555 from shalin@apache.org in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1647555 ] SOLR-6882 : Misspelled collection API actions in ReplicaMutator exception messages
        Hide
        Shalin Shekhar Mangar added a comment -

        Thanks Steve!

        I also renamed the ReplicaMutator.removeReplicaProperty method to deleteReplicaProperty to match the overseer action name.

        Show
        Shalin Shekhar Mangar added a comment - Thanks Steve! I also renamed the ReplicaMutator.removeReplicaProperty method to deleteReplicaProperty to match the overseer action name.
        Hide
        Anshum Gupta added a comment -

        Bulk close after 5.0 release.

        Show
        Anshum Gupta added a comment - Bulk close after 5.0 release.

          People

          • Assignee:
            Shalin Shekhar Mangar
            Reporter:
            Steve Rowe
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development