Solr
  1. Solr
  2. SOLR-6874

There is a race around SocketProxy binding to it's port the way we setup JettySolrRunner and SocketProxy.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.0, 6.0
    • Component/s: None
    • Labels:
      None

      Description

      I ran into this while working on SOLR-4509 and have a fix there in my latest patch. Because we get an available port by opening and closing a scocket on port 0 and then try to use it again with the SocketProxy, sometimes it fails to bind and the test can fail. We can change the code a bit so that the SocketProxy itself can start on port 0 rather than this two step fragile process.

      1. SOLR-6874.patch
        11 kB
        Timothy Potter

        Issue Links

          Activity

          Hide
          Timothy Potter added a comment -

          Thanks for fixing this Mark! I needed this to get the hangs resolved for SOLR-4839 so pulled your changes from the other ticket into this patch and added a few changes of my own.

          Show
          Timothy Potter added a comment - Thanks for fixing this Mark! I needed this to get the hangs resolved for SOLR-4839 so pulled your changes from the other ticket into this patch and added a few changes of my own.
          Hide
          Shalin Shekhar Mangar added a comment -

          +1 to commit.

          This resolves the failures seen in SOLR-4839 as well.

          Show
          Shalin Shekhar Mangar added a comment - +1 to commit. This resolves the failures seen in SOLR-4839 as well.
          Hide
          ASF subversion and git services added a comment -

          Commit 1649154 from Timothy Potter in branch 'dev/trunk'
          [ https://svn.apache.org/r1649154 ]

          SOLR-6874: There is a race around SocketProxy binding to it's port the way we setup JettySolrRunner and SocketProxy.

          Show
          ASF subversion and git services added a comment - Commit 1649154 from Timothy Potter in branch 'dev/trunk' [ https://svn.apache.org/r1649154 ] SOLR-6874 : There is a race around SocketProxy binding to it's port the way we setup JettySolrRunner and SocketProxy.
          Hide
          ASF subversion and git services added a comment -

          Commit 1649665 from Timothy Potter in branch 'dev/branches/branch_5x'
          [ https://svn.apache.org/r1649665 ]

          SOLR-6874: There is a race around SocketProxy binding to it's port the way we setup JettySolrRunner and SocketProxy.

          Show
          ASF subversion and git services added a comment - Commit 1649665 from Timothy Potter in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1649665 ] SOLR-6874 : There is a race around SocketProxy binding to it's port the way we setup JettySolrRunner and SocketProxy.
          Hide
          Anshum Gupta added a comment -

          Bulk close after 5.0 release.

          Show
          Anshum Gupta added a comment - Bulk close after 5.0 release.

            People

            • Assignee:
              Timothy Potter
              Reporter:
              Mark Miller
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development