Details

    • Type: Task Task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 5.0
    • Fix Version/s: 5.2, 6.0
    • Component/s: None
    • Labels:
      None

      Description

      HttpClient 4.4 has been released. 5.0 seems like a good time to upgrade.

      1. SOLR-6865.patch
        4 kB
        Shawn Heisey
      2. SOLR-6865.patch
        5 kB
        Shawn Heisey

        Activity

        Hide
        Shawn Heisey added a comment -

        It will take me a couple of days to do the required testing to see if any code changes are required. If anyone else wants to swipe this issue, feel free.

        Show
        Shawn Heisey added a comment - It will take me a couple of days to do the required testing to see if any code changes are required. If anyone else wants to swipe this issue, feel free.
        Hide
        Shawn Heisey added a comment - - edited

        I was wondering whether we should mention HttpClient in the "Versions of Major Components" section for each release. It is a critical component of SolrCloud and SolrJ.

        Show
        Shawn Heisey added a comment - - edited I was wondering whether we should mention HttpClient in the "Versions of Major Components" section for each release. It is a critical component of SolrCloud and SolrJ.
        Hide
        Shawn Heisey added a comment -

        The new HC version is not yet pushed to the maven repo that ivy is querying. Based on the response I got when I asked about it on the mailing list, I suspect that they are not checking for mirror penetration before releases are announced.

        Show
        Shawn Heisey added a comment - The new HC version is not yet pushed to the maven repo that ivy is querying. Based on the response I got when I asked about it on the mailing list, I suspect that they are not checking for mirror penetration before releases are announced.
        Hide
        Shawn Heisey added a comment -

        I can see the 4.4 version on the central maven repository ... is it normal for ivy to only try the uk mirror and not try any other mirrors? I'm in the US, so I was surprised to see it going to uk.maven.org at all.

        I seem to recall with other jars that ivy would try multiple mirrors before failing, but that doesn't seem to be happening for httpclient.

        Show
        Shawn Heisey added a comment - I can see the 4.4 version on the central maven repository ... is it normal for ivy to only try the uk mirror and not try any other mirrors? I'm in the US, so I was surprised to see it going to uk.maven.org at all. I seem to recall with other jars that ivy would try multiple mirrors before failing, but that doesn't seem to be happening for httpclient.
        Hide
        Shawn Heisey added a comment -

        Looks like I was wrong about it being on maven central. Only httpcore-4.4.jar is there, and that's on the uk mirror as well. The other two jars we need for 4.4 are not present on either central or uk.

        Show
        Shawn Heisey added a comment - Looks like I was wrong about it being on maven central. Only httpcore-4.4.jar is there, and that's on the uk mirror as well. The other two jars we need for 4.4 are not present on either central or uk.
        Hide
        Shawn Heisey added a comment -

        It is trying other mirrors. No idea how I missed that when I reviewed the output before.

        Show
        Shawn Heisey added a comment - It is trying other mirrors. No idea how I missed that when I reviewed the output before.
        Hide
        Shawn Heisey added a comment -

        I misread the HC release announcement. It's a new release of httpcore, not the entire httpcomponents suite. I'll just leave this open and try the upgrade once the full release is made.

        Show
        Shawn Heisey added a comment - I misread the HC release announcement. It's a new release of httpcore, not the entire httpcomponents suite. I'll just leave this open and try the upgrade once the full release is made.
        Hide
        Shawn Heisey added a comment -

        The full release is official now, early indications are that all tests will pass on 5x.

        Show
        Shawn Heisey added a comment - The full release is official now, early indications are that all tests will pass on 5x.
        Hide
        Shawn Heisey added a comment -

        This patch passes all tests in branch_5x. It almost passes precommit, but the failure is unrelated to this issue, and can be fixed by adding javadoc to one method.

        Show
        Shawn Heisey added a comment - This patch passes all tests in branch_5x. It almost passes precommit, but the failure is unrelated to this issue, and can be fixed by adding javadoc to one method.
        Hide
        Shawn Heisey added a comment -

        The javadoc problem was noticed and corrected by its author, so my patch is ready.

        Show
        Shawn Heisey added a comment - The javadoc problem was noticed and corrected by its author, so my patch is ready.
        Hide
        Shawn Heisey added a comment -

        After thinking about this, I think it might be a good idea to wait for 4.4.1 to be released, and monitor the httpclient mailing list for a week or so, before upgrading. I think that's the best way to assure stability for this important component.

        If a serious problem in the current 4.3 release crops up that's fixed in 4.4, I can do the upgrade immediately.

        Show
        Shawn Heisey added a comment - After thinking about this, I think it might be a good idea to wait for 4.4.1 to be released, and monitor the httpclient mailing list for a week or so, before upgrading. I think that's the best way to assure stability for this important component. If a serious problem in the current 4.3 release crops up that's fixed in 4.4, I can do the upgrade immediately.
        Hide
        Shawn Heisey added a comment -

        The httpcore module has advanced to 4.4.1, asking on the HC list to find out if any of the other modules will see a 4.4.1 release.

        Show
        Shawn Heisey added a comment - The httpcore module has advanced to 4.4.1, asking on the HC list to find out if any of the other modules will see a 4.4.1 release.
        Hide
        Oleg Kalnichevski added a comment -

        Yes, they will. I am going to put HttpClient 4.4.1 on vote next week.

        Oleg

        Show
        Oleg Kalnichevski added a comment - Yes, they will. I am going to put HttpClient 4.4.1 on vote next week. Oleg
        Hide
        Karl Wright added a comment -

        Have the deprecation warnings been cleaned up in Solr 5.0? When I looked at it last, there were significant structural issues with making those warnings go away because of the builder-style httpclient 4.3 paradigm. I believe 4.4 makes the deprecated code go away entirely.

        Show
        Karl Wright added a comment - Have the deprecation warnings been cleaned up in Solr 5.0? When I looked at it last, there were significant structural issues with making those warnings go away because of the builder-style httpclient 4.3 paradigm. I believe 4.4 makes the deprecated code go away entirely.
        Hide
        Shawn Heisey added a comment -

        SOLR-5604 is the issue where I talk about deprecations in HC.

        I have already tried the HttpClient 4.4 upgrade in Solr without any new test failures, and I'm using HC 4.4 in my own SolrJ code, so I know they have not removed the deprecated methods. I am confident that HC uses the same deprecation policy that we do, which indicates that the deprecated code will not be removed until HC 5.0.

        As I indicated on SOLR-5604, It looks like HC is slowly gearing up for a 5.0-alpha release, though I cannot tell how quickly those plans are proceeding. Perhaps Oleg Kalnichevski can fill in the blanks.

        Show
        Shawn Heisey added a comment - SOLR-5604 is the issue where I talk about deprecations in HC. I have already tried the HttpClient 4.4 upgrade in Solr without any new test failures, and I'm using HC 4.4 in my own SolrJ code, so I know they have not removed the deprecated methods. I am confident that HC uses the same deprecation policy that we do, which indicates that the deprecated code will not be removed until HC 5.0. As I indicated on SOLR-5604 , It looks like HC is slowly gearing up for a 5.0-alpha release, though I cannot tell how quickly those plans are proceeding. Perhaps Oleg Kalnichevski can fill in the blanks.
        Hide
        Oleg Kalnichevski added a comment - - edited

        Shawn et al
        HC 5.0 was initially going to be 4.x sans all deprecated stuff plus changes required for compliance with RFC 7230 and related specs. With such scope HC 5.0 was likely to stabilize in a fairly short period of time. Now that the scope has been expanded to include partial support for HTTP/2 HC 5.0 development will take significantly longer. It will be at least a year before HC 5.0 is anywhere near a GA release.

        Show
        Oleg Kalnichevski added a comment - - edited Shawn et al HC 5.0 was initially going to be 4.x sans all deprecated stuff plus changes required for compliance with RFC 7230 and related specs. With such scope HC 5.0 was likely to stabilize in a fairly short period of time. Now that the scope has been expanded to include partial support for HTTP/2 HC 5.0 development will take significantly longer. It will be at least a year before HC 5.0 is anywhere near a GA release.
        Hide
        Shawn Heisey added a comment -

        I plan on committing to 5x and trunk tonight. I will leave the 5.1 branch alone.

        Show
        Shawn Heisey added a comment - I plan on committing to 5x and trunk tonight. I will leave the 5.1 branch alone.
        Hide
        Shawn Heisey added a comment -

        New patch. Committing after verifying tests and precommit.

        Show
        Shawn Heisey added a comment - New patch. Committing after verifying tests and precommit.
        Hide
        Shawn Heisey added a comment -

        I needed to add 'svn:eol-style native' on the new hash files. Not in patch, but it will be in the commit. Shouldn't jar-checksums do that for us automatically?

        Show
        Shawn Heisey added a comment - I needed to add 'svn:eol-style native' on the new hash files. Not in patch, but it will be in the commit. Shouldn't jar-checksums do that for us automatically?
        Hide
        Shawn Heisey added a comment -

        Now that I think about it, jar-checksums didn't touch svn at all, I had to do that. I think the local SVN install can be configured to automatically use certain properties for configured extensions, but can an SVN checkout be configured with such settings so the user doesn't have to do it locally?

        Show
        Shawn Heisey added a comment - Now that I think about it, jar-checksums didn't touch svn at all, I had to do that. I think the local SVN install can be configured to automatically use certain properties for configured extensions, but can an SVN checkout be configured with such settings so the user doesn't have to do it locally?
        Hide
        ASF subversion and git services added a comment -

        Commit 1671085 from Shawn Heisey in branch 'dev/trunk'
        [ https://svn.apache.org/r1671085 ]

        SOLR-6865: Upgrade HttpClient/Core/Mime to 4.4.1.

        Show
        ASF subversion and git services added a comment - Commit 1671085 from Shawn Heisey in branch 'dev/trunk' [ https://svn.apache.org/r1671085 ] SOLR-6865 : Upgrade HttpClient/Core/Mime to 4.4.1.
        Hide
        ASF subversion and git services added a comment -

        Commit 1671092 from Shawn Heisey in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1671092 ]

        SOLR-6865: Upgrade HttpClient/Core/Mime to 4.4.1. (merge trunk r1671085)

        Show
        ASF subversion and git services added a comment - Commit 1671092 from Shawn Heisey in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1671092 ] SOLR-6865 : Upgrade HttpClient/Core/Mime to 4.4.1. (merge trunk r1671085)
        Hide
        Shawn Heisey added a comment -

        Tests and precommit passed on trunk before that change was committed.

        Precommit passed on 5x before that change was committed. Tests passed successfully shortly after the commit.

        Show
        Shawn Heisey added a comment - Tests and precommit passed on trunk before that change was committed. Precommit passed on 5x before that change was committed. Tests passed successfully shortly after the commit.
        Hide
        Anshum Gupta added a comment -

        Bulk close for 5.2.0.

        Show
        Anshum Gupta added a comment - Bulk close for 5.2.0.

          People

          • Assignee:
            Shawn Heisey
            Reporter:
            Shawn Heisey
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development