Solr
  1. Solr
  2. SOLR-6852

SimplePostTool should no longer default to collection1

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.0
    • Component/s: None
    • Labels:
      None

      Description

      Solr no longer would be bootstrapped with "collection1" and so it no longer makes sense for the SimplePostTool to default to collection1 either.
      Without an explicit collection/core/url value, the call should just fail fast.

      1. SOLR-6852.patch
        9 kB
        Anshum Gupta
      2. SOLR-6852.patch
        7 kB
        Anshum Gupta

        Activity

        Hide
        Hoss Man added a comment -

        +1

        Show
        Hoss Man added a comment - +1
        Hide
        Anshum Gupta added a comment -

        With that, there's another question. Should the default URL be also dropped? I'd like to drop the default behavior and force users to specify the collection/core name.

        It currently defaults to:
        http://localhost:8983/solr/collection1/update.

        Show
        Anshum Gupta added a comment - With that, there's another question. Should the default URL be also dropped? I'd like to drop the default behavior and force users to specify the collection/core name. It currently defaults to: http://localhost:8983/solr/collection1/update .
        Hide
        Hoss Man added a comment -

        given that post.jar's primary goal is making things simple for new users – particularly users trying out hte examples & tutorial – i think that as long as the user specifies a collection name, it's find to have default assumptions about http, localhost, 8983, /solr, and /update.

        if any of those things aren't what the user wants then they can use the full URL, just like with curl.

        Show
        Hoss Man added a comment - given that post.jar's primary goal is making things simple for new users – particularly users trying out hte examples & tutorial – i think that as long as the user specifies a collection name, it's find to have default assumptions about http, localhost, 8983, /solr, and /update. if any of those things aren't what the user wants then they can use the full URL, just like with curl.
        Hide
        Anshum Gupta added a comment -

        right, that's what I'm checking on.

        if(url==null && core== null) {
         fatal(....);
        }
        
        Show
        Anshum Gupta added a comment - right, that's what I'm checking on. if (url== null && core== null ) { fatal(....); }
        Hide
        Anshum Gupta added a comment -

        Patch for SimplePostTool and README.txt.

        Show
        Anshum Gupta added a comment - Patch for SimplePostTool and README.txt.
        Hide
        Anshum Gupta added a comment -

        Fixing the failing test.

        Show
        Anshum Gupta added a comment - Fixing the failing test.
        Hide
        Anshum Gupta added a comment -

        Fixed the test to set a dummy collection when testing the SimplePostTool so it doesn't fail fast.

        Show
        Anshum Gupta added a comment - Fixed the test to set a dummy collection when testing the SimplePostTool so it doesn't fail fast.
        Hide
        Jack Krupansky added a comment -

        Is this really for 5.0 only and not trunk/6.0 as well?

        Show
        Jack Krupansky added a comment - Is this really for 5.0 only and not trunk/6.0 as well?
        Hide
        Anshum Gupta added a comment -

        No reason for this to be not for trunk too.

        Show
        Anshum Gupta added a comment - No reason for this to be not for trunk too.
        Hide
        ASF subversion and git services added a comment -

        Commit 1645866 from Anshum Gupta in branch 'dev/trunk'
        [ https://svn.apache.org/r1645866 ]

        SOLR-6852: SimplePostTool no longer defaults to collection1, also there's no default update URL

        Show
        ASF subversion and git services added a comment - Commit 1645866 from Anshum Gupta in branch 'dev/trunk' [ https://svn.apache.org/r1645866 ] SOLR-6852 : SimplePostTool no longer defaults to collection1, also there's no default update URL
        Hide
        ASF subversion and git services added a comment -

        Commit 1645867 from Anshum Gupta in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1645867 ]

        SOLR-6852: SimplePostTool no longer defaults to collection1, also there's no default update URL (merge from trunk)

        Show
        ASF subversion and git services added a comment - Commit 1645867 from Anshum Gupta in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1645867 ] SOLR-6852 : SimplePostTool no longer defaults to collection1, also there's no default update URL (merge from trunk)
        Hide
        ASF subversion and git services added a comment -

        Commit 1645868 from Anshum Gupta in branch 'dev/trunk'
        [ https://svn.apache.org/r1645868 ]

        SOLR-6852: Adding the CHANGES.txt entry

        Show
        ASF subversion and git services added a comment - Commit 1645868 from Anshum Gupta in branch 'dev/trunk' [ https://svn.apache.org/r1645868 ] SOLR-6852 : Adding the CHANGES.txt entry
        Hide
        ASF subversion and git services added a comment -

        Commit 1645869 from Anshum Gupta in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1645869 ]

        SOLR-6852: Adding the CHANGES.txt entry (Merging from trunk)

        Show
        ASF subversion and git services added a comment - Commit 1645869 from Anshum Gupta in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1645869 ] SOLR-6852 : Adding the CHANGES.txt entry (Merging from trunk)
        Hide
        ASF subversion and git services added a comment -

        Commit 1646032 from Anshum Gupta in branch 'dev/trunk'
        [ https://svn.apache.org/r1646032 ]

        SOLR-6852: Updating the CHANGES.txt entry to the 'Upgrading from..' section

        Show
        ASF subversion and git services added a comment - Commit 1646032 from Anshum Gupta in branch 'dev/trunk' [ https://svn.apache.org/r1646032 ] SOLR-6852 : Updating the CHANGES.txt entry to the 'Upgrading from..' section
        Hide
        ASF subversion and git services added a comment -

        Commit 1646033 from Anshum Gupta in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1646033 ]

        SOLR-6852: Updating the CHANGES.txt entry to the 'Upgrading from..' section (merge from trunk)

        Show
        ASF subversion and git services added a comment - Commit 1646033 from Anshum Gupta in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1646033 ] SOLR-6852 : Updating the CHANGES.txt entry to the 'Upgrading from..' section (merge from trunk)
        Hide
        Alexandre Rafalovitch added a comment -

        What about post.sh? That's got the URL hard-coded in as far as I can tell.

        Show
        Alexandre Rafalovitch added a comment - What about post.sh? That's got the URL hard-coded in as far as I can tell.
        Hide
        Anshum Gupta added a comment -

        I'll create another JIRA to perhaps just (re)move post.sh as it doesn't accept anything but a list of files. We need a bin/post script that does more than what example/exampledocs/post.sh does.

        Show
        Anshum Gupta added a comment - I'll create another JIRA to perhaps just (re)move post.sh as it doesn't accept anything but a list of files. We need a bin/post script that does more than what example/exampledocs/post.sh does.
        Hide
        Anshum Gupta added a comment -

        Also, post.sh doesn't do anything using the SimplePostTool and just uses curl and default URL to post files.
        SOLR-6435 should be a replacement for this but anyways, it's a different issue.

        Show
        Anshum Gupta added a comment - Also, post.sh doesn't do anything using the SimplePostTool and just uses curl and default URL to post files. SOLR-6435 should be a replacement for this but anyways, it's a different issue.
        Hide
        Anshum Gupta added a comment -

        Bulk close after 5.0 release.

        Show
        Anshum Gupta added a comment - Bulk close after 5.0 release.

          People

          • Assignee:
            Anshum Gupta
            Reporter:
            Anshum Gupta
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development