Solr
  1. Solr
  2. SOLR-6850

AutoAddReplicas does not wait enough for a replica to get live

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 4.10, 4.10.1, 4.10.2, 5.0, 6.0
    • Fix Version/s: 4.10.4, 5.0, 6.0
    • Component/s: None
    • Labels:
      None

      Description

      After we have detected that a replica needs failing over, we add a replica and wait to see if it's live.

      Currently we only wait for 30ms , but I think the intention here was to wait for 30s.

      In CloudStateUtil.waitToSeeLive() the conversion should have been System.nanoTime() + TimeUnit.NANOSECONDS.convert(timeoutInMs, TimeUnit.SECONDS); instead of System.nanoTime() + TimeUnit.NANOSECONDS.convert(timeoutInMs, TimeUnit.MILLISECONDS);

      1. SOLR-6850.patch
        1.0 kB
        Varun Thacker
      2. SOLR-6850.patch
        1 kB
        Varun Thacker

        Activity

        Hide
        Varun Thacker added a comment -

        Simple patch.

        Show
        Varun Thacker added a comment - Simple patch.
        Hide
        Varun Thacker added a comment -

        Whoops I created the previous patch too fast.

        ClusterStateUtil.waitToSeeLive() has a timeoutInMs param. So keeping that consistent and OverseerAutoReplicaFailoverThread.addReplica calls it correctly.

        Show
        Varun Thacker added a comment - Whoops I created the previous patch too fast. ClusterStateUtil.waitToSeeLive() has a timeoutInMs param. So keeping that consistent and OverseerAutoReplicaFailoverThread.addReplica calls it correctly.
        Hide
        Varun Thacker added a comment -

        Mark Miller What are your thoughts on this?

        Show
        Varun Thacker added a comment - Mark Miller What are your thoughts on this?
        Hide
        Mark Miller added a comment -

        Good catch Varun! I just took a look and this is actually fixed in Cloudera Search - whoops. I'll sync up and see if there is any other changes I have that are missing after committing this.

        Show
        Mark Miller added a comment - Good catch Varun! I just took a look and this is actually fixed in Cloudera Search - whoops. I'll sync up and see if there is any other changes I have that are missing after committing this.
        Hide
        ASF subversion and git services added a comment -

        Commit 1647460 from Mark Miller in branch 'dev/trunk'
        [ https://svn.apache.org/r1647460 ]

        SOLR-6850: AutoAddReplicas makes a call to wait to see live replicas that times out after 30 milliseconds instead of 30 seconds.

        Show
        ASF subversion and git services added a comment - Commit 1647460 from Mark Miller in branch 'dev/trunk' [ https://svn.apache.org/r1647460 ] SOLR-6850 : AutoAddReplicas makes a call to wait to see live replicas that times out after 30 milliseconds instead of 30 seconds.
        Hide
        ASF subversion and git services added a comment -

        Commit 1647461 from Mark Miller in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1647461 ]

        SOLR-6850: AutoAddReplicas makes a call to wait to see live replicas that times out after 30 milliseconds instead of 30 seconds.

        Show
        ASF subversion and git services added a comment - Commit 1647461 from Mark Miller in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1647461 ] SOLR-6850 : AutoAddReplicas makes a call to wait to see live replicas that times out after 30 milliseconds instead of 30 seconds.
        Hide
        Mark Miller added a comment -

        Thanks Varun!

        Show
        Mark Miller added a comment - Thanks Varun!
        Hide
        Anshum Gupta added a comment -

        Bulk close after 5.0 release.

        Show
        Anshum Gupta added a comment - Bulk close after 5.0 release.
        Hide
        Shalin Shekhar Mangar added a comment -

        Reopening to backport to 4.10.4

        Show
        Shalin Shekhar Mangar added a comment - Reopening to backport to 4.10.4
        Hide
        ASF subversion and git services added a comment -

        Commit 1662446 from shalin@apache.org in branch 'dev/branches/lucene_solr_4_10'
        [ https://svn.apache.org/r1662446 ]

        SOLR-6850: AutoAddReplicas makes a call to wait to see live replicas that times out after 30 milliseconds instead of 30 seconds.

        Show
        ASF subversion and git services added a comment - Commit 1662446 from shalin@apache.org in branch 'dev/branches/lucene_solr_4_10' [ https://svn.apache.org/r1662446 ] SOLR-6850 : AutoAddReplicas makes a call to wait to see live replicas that times out after 30 milliseconds instead of 30 seconds.
        Hide
        Michael McCandless added a comment -

        Bulk close for 4.10.4 release

        Show
        Michael McCandless added a comment - Bulk close for 4.10.4 release

          People

          • Assignee:
            Mark Miller
            Reporter:
            Varun Thacker
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development