[SOLR-6847] LeaderInitiatedRecoveryThread compares wrong replica's state with lirState

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 4.10.2
• Fix Version/s: 4.10.4, 5.0, 6.0
• Component/s: SolrCloud
• Assignee: Steven Rowe
• Reporter: Shalin Shekhar Mangar
• Created: 14/Dec/14 13:53
• Updated: 09/May/16 18:54
• Resolved: 27/Feb/15 19:00

Description

LeaderInitiatedRecoveryThread looks at a random replica to figure out if it should re-publish LIR state to "down". It does however publish the LIR state for the correct replica.

The bug has always been there. The thread used ZkStateReader.getReplicaProps method with the coreName to find the correct replica. However, the coreName parameter in getReplicaProps was un-used and I removed it in SOLR-6240 but I didn't find and fix this bug then.

The possible side-effects of this bug would be that we may be republish LIR state multiple times and/or in rare cases, cause double 'requestrecovery' to be executed on a replica.