Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-6812

distrib.singlePass does not work for expand-request

    Details

      Description

      Using distrib.singlePass does not work for expand-requests.

      1. fix.patch
        2 kB
        Per Steffensen
      2. SOLR-6812.patch
        3 kB
        Shalin Shekhar Mangar
      3. test_that_reveals_the_problem.patch
        1 kB
        Per Steffensen

        Issue Links

          Activity

          Hide
          steff1193 Per Steffensen added a comment -

          Attached patch (branch_5x) that change an existing test to reveal the problem. Apply the patch and run DistributedExpandComponentTest
          Probably not just want to commit the changed test after a fix of the problem, but maybe we want to add the test somewhere else.

          Show
          steff1193 Per Steffensen added a comment - Attached patch (branch_5x) that change an existing test to reveal the problem. Apply the patch and run DistributedExpandComponentTest Probably not just want to commit the changed test after a fix of the problem, but maybe we want to add the test somewhere else.
          Hide
          steff1193 Per Steffensen added a comment - - edited

          Attached a fix to the problem. Problem is that ExpandComponent kinda "detects" that it is supposed to do its thing for shard-searches, by seeing if ids-param is there. It is not in case of distrib.singlePass.
          Patch works on purpose instead, because that is really whats controlling the things in QueryComponent. So now purpose is distributed in the shard-requests.

          Show
          steff1193 Per Steffensen added a comment - - edited Attached a fix to the problem. Problem is that ExpandComponent kinda "detects" that it is supposed to do its thing for shard-searches, by seeing if ids-param is there. It is not in case of distrib.singlePass . Patch works on purpose instead, because that is really whats controlling the things in QueryComponent . So now purpose is distributed in the shard-requests.
          Hide
          shalinmangar Shalin Shekhar Mangar added a comment -

          As you noted, the ExpandComponent relied on whether IDs were present to detect whether it needs to operate but it should have relied on the "expand=true" param to do that as other components do.

          Patch uses modifyRequest method in ExpandComponent to send expand=true to shards only if either distrib.singlePass=true or purpose is GET_FIELDS.

          Show
          shalinmangar Shalin Shekhar Mangar added a comment - As you noted, the ExpandComponent relied on whether IDs were present to detect whether it needs to operate but it should have relied on the "expand=true" param to do that as other components do. Patch uses modifyRequest method in ExpandComponent to send expand=true to shards only if either distrib.singlePass=true or purpose is GET_FIELDS.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 1645098 from shalin@apache.org in branch 'dev/trunk'
          [ https://svn.apache.org/r1645098 ]

          SOLR-6604: SOLR-6812: Fix NPE with distrib.singlePass=true and expand component. Increased test coverage of expand component with docValues.

          This closes #98.

          Show
          jira-bot ASF subversion and git services added a comment - Commit 1645098 from shalin@apache.org in branch 'dev/trunk' [ https://svn.apache.org/r1645098 ] SOLR-6604 : SOLR-6812 : Fix NPE with distrib.singlePass=true and expand component. Increased test coverage of expand component with docValues. This closes #98.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 1645099 from shalin@apache.org in branch 'dev/branches/branch_5x'
          [ https://svn.apache.org/r1645099 ]

          SOLR-6604: SOLR-6812: Fix NPE with distrib.singlePass=true and expand component. Increased test coverage of expand component with docValues.

          This closes #98.

          Show
          jira-bot ASF subversion and git services added a comment - Commit 1645099 from shalin@apache.org in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1645099 ] SOLR-6604 : SOLR-6812 : Fix NPE with distrib.singlePass=true and expand component. Increased test coverage of expand component with docValues. This closes #98.
          Hide
          shalinmangar Shalin Shekhar Mangar added a comment -

          I committed the fix combined with SOLR-6604.

          Thanks Per!

          Show
          shalinmangar Shalin Shekhar Mangar added a comment - I committed the fix combined with SOLR-6604 . Thanks Per!
          Hide
          anshumg Anshum Gupta added a comment -

          Bulk close after 5.0 release.

          Show
          anshumg Anshum Gupta added a comment - Bulk close after 5.0 release.

            People

            • Assignee:
              shalinmangar Shalin Shekhar Mangar
              Reporter:
              steff1193 Per Steffensen
            • Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development