Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-6804

Untangle SnapPuller and ReplicationHandler

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.1
    • Component/s: replication (java)
    • Labels:
      None

      Description

      Spinoff from SOLR-6793

      • Move the polling functionality from SnapPuller to ReplicationHandler
      • Rename SnapPuller to IndexFetcher, and their instances in ReplicationHandler for clarity
      1. SOLR-6804.patch
        107 kB
        Ramkumar Aiyengar

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user andyetitmoves opened a pull request:

        https://github.com/apache/lucene-solr/pull/110

        Untangle SnapPuller and ReplicationHandler

        Initial patch for SOLR-6804.

        I haven't got to the last point (merging snapPuller and tempSnapPuller), I will get to it after SOLR-6500 is done, otherwise it will be one messy merge..

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/bloomberg/lucene-solr trunk-refactor-snap

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/lucene-solr/pull/110.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #110


        commit 57a4cad011fdc903b7ce97ef201966ae30ebc467
        Author: Ramkumar Aiyengar <andyetitmoves@gmail.com>
        Date: 2014-11-26T23:55:58Z

        Move polling parameters from SnapPuller to ReplicationHandler, other refactoring

        commit 09c7b0a598f297cb10991e76fc7f7650d2052422
        Author: Ramkumar Aiyengar <andyetitmoves@gmail.com>
        Date: 2014-11-27T21:43:44Z

        Rename SnapPuller to IndexFetcher


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user andyetitmoves opened a pull request: https://github.com/apache/lucene-solr/pull/110 Untangle SnapPuller and ReplicationHandler Initial patch for SOLR-6804 . I haven't got to the last point (merging snapPuller and tempSnapPuller), I will get to it after SOLR-6500 is done, otherwise it will be one messy merge.. You can merge this pull request into a Git repository by running: $ git pull https://github.com/bloomberg/lucene-solr trunk-refactor-snap Alternatively you can review and apply these changes as the patch at: https://github.com/apache/lucene-solr/pull/110.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #110 commit 57a4cad011fdc903b7ce97ef201966ae30ebc467 Author: Ramkumar Aiyengar <andyetitmoves@gmail.com> Date: 2014-11-26T23:55:58Z Move polling parameters from SnapPuller to ReplicationHandler, other refactoring commit 09c7b0a598f297cb10991e76fc7f7650d2052422 Author: Ramkumar Aiyengar <andyetitmoves@gmail.com> Date: 2014-11-27T21:43:44Z Rename SnapPuller to IndexFetcher
        Hide
        andyetitmoves Ramkumar Aiyengar added a comment -

        Unifying the index fetchers is actually only going to complicate things further, so I am going to settle for just renaming them ('temp' doesn't quite describe it correctly as it could actually be permanent!). The patch should now be ready now..

        Show
        andyetitmoves Ramkumar Aiyengar added a comment - Unifying the index fetchers is actually only going to complicate things further, so I am going to settle for just renaming them ('temp' doesn't quite describe it correctly as it could actually be permanent!). The patch should now be ready now..
        Hide
        andyetitmoves Ramkumar Aiyengar added a comment -

        Mark Miller, these are changes we discussed about in SOLR-6793. If you can take a quick look before I commit, that would be great..

        Show
        andyetitmoves Ramkumar Aiyengar added a comment - Mark Miller , these are changes we discussed about in SOLR-6793 . If you can take a quick look before I commit, that would be great..
        Hide
        noble.paul Noble Paul added a comment -

        makes sense.
        Shalin Shekhar Mangar was talking about using the Lucene's replication functionality

        Show
        noble.paul Noble Paul added a comment - makes sense. Shalin Shekhar Mangar was talking about using the Lucene's replication functionality
        Hide
        markrmiller@gmail.com Mark Miller added a comment -

        +1, I like this change - patch looks great.

        Show
        markrmiller@gmail.com Mark Miller added a comment - +1, I like this change - patch looks great.
        Hide
        shalinmangar Shalin Shekhar Mangar added a comment -

        +1 LGTM.

        Show
        shalinmangar Shalin Shekhar Mangar added a comment - +1 LGTM.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 1664126 from andyetitmoves@apache.org in branch 'dev/trunk'
        [ https://svn.apache.org/r1664126 ]

        SOLR-6804: Untangle SnapPuller and ReplicationHandler

        This closes #110

        Show
        jira-bot ASF subversion and git services added a comment - Commit 1664126 from andyetitmoves@apache.org in branch 'dev/trunk' [ https://svn.apache.org/r1664126 ] SOLR-6804 : Untangle SnapPuller and ReplicationHandler This closes #110
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/lucene-solr/pull/110

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/lucene-solr/pull/110
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 1664147 from andyetitmoves@apache.org in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1664147 ]

        SOLR-6804: Untangle SnapPuller and ReplicationHandler

        Show
        jira-bot ASF subversion and git services added a comment - Commit 1664147 from andyetitmoves@apache.org in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1664147 ] SOLR-6804 : Untangle SnapPuller and ReplicationHandler
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 1664482 from andyetitmoves@apache.org in branch 'dev/trunk'
        [ https://svn.apache.org/r1664482 ]

        SOLR-6804: Add CHANGES.txt entry

        Show
        jira-bot ASF subversion and git services added a comment - Commit 1664482 from andyetitmoves@apache.org in branch 'dev/trunk' [ https://svn.apache.org/r1664482 ] SOLR-6804 : Add CHANGES.txt entry
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 1664484 from andyetitmoves@apache.org in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1664484 ]

        SOLR-6804: Add CHANGES.txt entry

        Show
        jira-bot ASF subversion and git services added a comment - Commit 1664484 from andyetitmoves@apache.org in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1664484 ] SOLR-6804 : Add CHANGES.txt entry
        Hide
        thelabdude Timothy Potter added a comment -

        Bulk close after 5.1 release

        Show
        thelabdude Timothy Potter added a comment - Bulk close after 5.1 release

          People

          • Assignee:
            andyetitmoves Ramkumar Aiyengar
            Reporter:
            andyetitmoves Ramkumar Aiyengar
          • Votes:
            1 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development