Solr
  1. Solr
  2. SOLR-6795

distrib.singlePass returns score even though not asked for

    Details

      Description

      If I pass distrib.singlePass in a request and do not ask for score back (fl does not include score) it will return the score back anyway.

      1. fix.patch
        0.8 kB
        Per Steffensen
      2. SOLR-6795.patch
        2 kB
        Shalin Shekhar Mangar
      3. test_that_reveals_the_problem.patch
        1 kB
        Per Steffensen

        Issue Links

          Activity

          Hide
          Per Steffensen added a comment -

          Attached patch (branch_5x) that change an existing test to reveal the problem. Apply the patch and run e.g. BasicDistributedZk2Test
          Probably not just want to commit the changed test after a fix of the problem, but maybe we want to add the test somewhere else. In my company we have an agreement that whenever we fix a bug, we also create a test that reveals it

          Show
          Per Steffensen added a comment - Attached patch (branch_5x) that change an existing test to reveal the problem. Apply the patch and run e.g. BasicDistributedZk2Test Probably not just want to commit the changed test after a fix of the problem, but maybe we want to add the test somewhere else. In my company we have an agreement that whenever we fix a bug, we also create a test that reveals it
          Hide
          Per Steffensen added a comment -

          Attached a fix to the problem. I believe it will not ruin other functionality - but I havnt run the entire test-suite with this patch

          Show
          Per Steffensen added a comment - Attached a fix to the problem. I believe it will not ruin other functionality - but I havnt run the entire test-suite with this patch
          Hide
          Shalin Shekhar Mangar added a comment -

          Thanks Per. I have moved your test to DistributedQueryComponentOptimizationTest which is where I've added the tests for this feature.

          I'll commit once the test suite passes.

          Show
          Shalin Shekhar Mangar added a comment - Thanks Per. I have moved your test to DistributedQueryComponentOptimizationTest which is where I've added the tests for this feature. I'll commit once the test suite passes.
          Hide
          ASF subversion and git services added a comment -

          Commit 1642774 from shalin@apache.org in branch 'dev/trunk'
          [ https://svn.apache.org/r1642774 ]

          SOLR-6795: distrib.singlePass returns score even though not asked for

          Show
          ASF subversion and git services added a comment - Commit 1642774 from shalin@apache.org in branch 'dev/trunk' [ https://svn.apache.org/r1642774 ] SOLR-6795 : distrib.singlePass returns score even though not asked for
          Hide
          ASF subversion and git services added a comment -

          Commit 1642775 from shalin@apache.org in branch 'dev/branches/branch_5x'
          [ https://svn.apache.org/r1642775 ]

          SOLR-6795: distrib.singlePass returns score even though not asked for

          Show
          ASF subversion and git services added a comment - Commit 1642775 from shalin@apache.org in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1642775 ] SOLR-6795 : distrib.singlePass returns score even though not asked for
          Hide
          ASF subversion and git services added a comment -

          Commit 1642776 from shalin@apache.org in branch 'dev/branches/lucene_solr_4_10'
          [ https://svn.apache.org/r1642776 ]

          SOLR-6795: distrib.singlePass returns score even though not asked for

          Show
          ASF subversion and git services added a comment - Commit 1642776 from shalin@apache.org in branch 'dev/branches/lucene_solr_4_10' [ https://svn.apache.org/r1642776 ] SOLR-6795 : distrib.singlePass returns score even though not asked for
          Hide
          Shalin Shekhar Mangar added a comment -

          I've backported this to 4.10.3 as well. Thanks Per!

          Show
          Shalin Shekhar Mangar added a comment - I've backported this to 4.10.3 as well. Thanks Per!
          Hide
          Anshum Gupta added a comment -

          Bulk close after 5.0 release.

          Show
          Anshum Gupta added a comment - Bulk close after 5.0 release.

            People

            • Assignee:
              Shalin Shekhar Mangar
              Reporter:
              Per Steffensen
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development