Solr
  1. Solr
  2. SOLR-6792

cleanup solrconfig.xml files by removing implicit plugins

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.0, 6.0
    • Component/s: None
    • Labels:
      None

      Description

      /replication , /get , /update, /admin/ are registered implicitly for each core. No need to specify them from solrconfig.xml if nothing custom needs to be added

        Activity

        Hide
        Noble Paul added a comment -

        This cleans up the solrconfig and deprecates the AdminHandlers class

        Show
        Noble Paul added a comment - This cleans up the solrconfig and deprecates the AdminHandlers class
        Hide
        ASF subversion and git services added a comment -

        Commit 1641790 from Noble Paul in branch 'dev/trunk'
        [ https://svn.apache.org/r1641790 ]

        SOLR-6792 deprecate AdminHandlers, Clean up solrconfig.xml of unnecessary plugin definitions, implicit registration of /replication, /get and /admin/* handlers

        Show
        ASF subversion and git services added a comment - Commit 1641790 from Noble Paul in branch 'dev/trunk' [ https://svn.apache.org/r1641790 ] SOLR-6792 deprecate AdminHandlers, Clean up solrconfig.xml of unnecessary plugin definitions, implicit registration of /replication, /get and /admin/* handlers
        Hide
        ASF subversion and git services added a comment -

        Commit 1641792 from Noble Paul in branch 'dev/trunk'
        [ https://svn.apache.org/r1641792 ]

        SOLR-6792 adding deprecation details

        Show
        ASF subversion and git services added a comment - Commit 1641792 from Noble Paul in branch 'dev/trunk' [ https://svn.apache.org/r1641792 ] SOLR-6792 adding deprecation details
        Hide
        ASF subversion and git services added a comment -

        Commit 1642025 from Noble Paul in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1642025 ]

        SOLR-6792 deprecate AdminHandlers, Clean up solrconfig.xml of unnecessary plugin definitions, implicit registration of /replication, /get and /admin/* handlers

        Show
        ASF subversion and git services added a comment - Commit 1642025 from Noble Paul in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1642025 ] SOLR-6792 deprecate AdminHandlers, Clean up solrconfig.xml of unnecessary plugin definitions, implicit registration of /replication, /get and /admin/* handlers
        Hide
        Alan Woodward added a comment -

        Hi Noble Paul, I think the CHANGES.txt entry for this has got a bit messed up?

        It would be helpful to have more deprecation information in the javadoc for the deprecated class as well - at the moment, it just tells you it's deprecated, it doesn't say what you should do instead.

        I also wonder if it's worth going through and removing explicit definitions from the various test and example solrconfig.xml files we have? And nuking the class entirely in trunk.

        Show
        Alan Woodward added a comment - Hi Noble Paul , I think the CHANGES.txt entry for this has got a bit messed up? It would be helpful to have more deprecation information in the javadoc for the deprecated class as well - at the moment, it just tells you it's deprecated, it doesn't say what you should do instead. I also wonder if it's worth going through and removing explicit definitions from the various test and example solrconfig.xml files we have? And nuking the class entirely in trunk.
        Hide
        Noble Paul added a comment - - edited

        And nuking the class entirely in trunk.

        We should give enough time to users to cleanup their solrconfig.xml files. TIll that point we will keep the class around

        I also wonder if it's worth going through and removing explicit definitions from the various test and example solrconfig.xml files we have?

        I think I have removed most references

        Show
        Noble Paul added a comment - - edited And nuking the class entirely in trunk. We should give enough time to users to cleanup their solrconfig.xml files. TIll that point we will keep the class around I also wonder if it's worth going through and removing explicit definitions from the various test and example solrconfig.xml files we have? I think I have removed most references
        Hide
        ASF subversion and git services added a comment -

        Commit 1648654 from Noble Paul in branch 'dev/trunk'
        [ https://svn.apache.org/r1648654 ]

        SOLR-6792 added javadocs

        Show
        ASF subversion and git services added a comment - Commit 1648654 from Noble Paul in branch 'dev/trunk' [ https://svn.apache.org/r1648654 ] SOLR-6792 added javadocs
        Hide
        Alan Woodward added a comment -

        I'm talking about trunk, though. If we keep deprecated classes hanging around in trunk on the off-chance that somebody building off trunk isn't following development closely, then we end up with things being carried over for several releases because nobody cleans anything up.

        CHANGES.txt is still borked, btw:

        * AdminHandlers is deprecated , /admin/* are implicitly defined, /get ,/replication and handlers are also implicitly registered (refer to SOLR-6792)

        Looks like there's a stray 'and' or something else missing there?

        Show
        Alan Woodward added a comment - I'm talking about trunk, though. If we keep deprecated classes hanging around in trunk on the off-chance that somebody building off trunk isn't following development closely, then we end up with things being carried over for several releases because nobody cleans anything up. CHANGES.txt is still borked, btw: * AdminHandlers is deprecated , /admin/* are implicitly defined, /get ,/replication and handlers are also implicitly registered (refer to SOLR-6792 ) Looks like there's a stray 'and' or something else missing there?
        Hide
        Noble Paul added a comment -

        Alan Woodward I'm not sure . What would you recommend?

        Show
        Noble Paul added a comment - Alan Woodward I'm not sure . What would you recommend?
        Hide
        Anshum Gupta added a comment -

        Bulk close after 5.0 release.

        Show
        Anshum Gupta added a comment - Bulk close after 5.0 release.

          People

          • Assignee:
            Noble Paul
            Reporter:
            Noble Paul
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development