Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-6773

Remove the multicore example as the DIH and cloud examples illustrate multicore behavior

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      As discussed in SOLR-3619, we should get rid of the multicore example; there are unit tests that rely on that directory so they will need to get refactored. May make sense to just move the multicore directory under test.

        Issue Links

          Activity

          Hide
          hossman Hoss Man added a comment -

          there are unit tests that rely on that directory so they will need to get refactored.

          the purpose of the unit tests was to have an automated sanity check that the example configs were functional.

          if the multicore example is removed (+1!), there is no longer any need for an automated test of those configs (it's like a catch-22, but in reverse)

          Show
          hossman Hoss Man added a comment - there are unit tests that rely on that directory so they will need to get refactored. the purpose of the unit tests was to have an automated sanity check that the example configs were functional. if the multicore example is removed (+1!), there is no longer any need for an automated test of those configs (it's like a catch-22, but in reverse)
          Hide
          thelabdude Timothy Potter added a comment -

          The only one I'm concerned about is the MergeIndexesEmbeddedTest which uses the two cores in multicore to test merge functionality. So I'm thinking I'll remove all but this test and then move example/multicore into a test-files location so that it's clear it is no longer an example but is used for testing cross-core behavior like merge.

          Show
          thelabdude Timothy Potter added a comment - The only one I'm concerned about is the MergeIndexesEmbeddedTest which uses the two cores in multicore to test merge functionality. So I'm thinking I'll remove all but this test and then move example/multicore into a test-files location so that it's clear it is no longer an example but is used for testing cross-core behavior like merge.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 1644461 from Timothy Potter in branch 'dev/trunk'
          [ https://svn.apache.org/r1644461 ]

          SOLR-6773: Remove the multicore example as the DIH and cloud examples illustrate multicore behavior

          Show
          jira-bot ASF subversion and git services added a comment - Commit 1644461 from Timothy Potter in branch 'dev/trunk' [ https://svn.apache.org/r1644461 ] SOLR-6773 : Remove the multicore example as the DIH and cloud examples illustrate multicore behavior
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 1644471 from Timothy Potter in branch 'dev/branches/branch_5x'
          [ https://svn.apache.org/r1644471 ]

          SOLR-6773: Remove the multicore example as the DIH and cloud examples illustrate multicore behavior

          Show
          jira-bot ASF subversion and git services added a comment - Commit 1644471 from Timothy Potter in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1644471 ] SOLR-6773 : Remove the multicore example as the DIH and cloud examples illustrate multicore behavior
          Hide
          arafalov Alexandre Rafalovitch added a comment -

          So, what are we going to have left in the example folder? Because people will be looking in it (a good name). Is it just DIH and exampledocs?

          Starting to look a bit weird.

          Show
          arafalov Alexandre Rafalovitch added a comment - So, what are we going to have left in the example folder? Because people will be looking in it (a good name). Is it just DIH and exampledocs? Starting to look a bit weird.
          Hide
          hossman Hoss Man added a comment -

          i still thin the example folder has value, see SOLR-6833.

          Show
          hossman Hoss Man added a comment - i still thin the example folder has value, see SOLR-6833 .
          Hide
          arafalov Alexandre Rafalovitch added a comment -

          SOLR-6833 makes sense to me. I raised the same issues around November 26 on SOLR-3619 . I think server directly should be as much as possible immutable. Certainly for examples.

          Show
          arafalov Alexandre Rafalovitch added a comment - SOLR-6833 makes sense to me. I raised the same issues around November 26 on SOLR-3619 . I think server directly should be as much as possible immutable. Certainly for examples.

            People

            • Assignee:
              thelabdude Timothy Potter
              Reporter:
              thelabdude Timothy Potter
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development