Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-6759

ExpandComponent does not call finish() on DelegatingCollectors

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Open
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: 4.10.5
    • Component/s: query parsers
    • Labels:
      None

      Description

      We have a PostFilter for ACL filtering in action that has a similar structure as CollapsingQParserPlugin, i.e. it's DelegatingCollector gathers all documents and calls delegate.collect() for all docs finally in its finish() method.

      In contrast to CollapsingQParserPlugin our PostFilter is also called by the ExpandComponent (for purpose).
      But as the finish method is never called by the ExpandComponent, the "expand" section in the result is always empty.

      Tested with Solr 4.10.2.

        Attachments

        1. ExpandComponent.java.patch
          2 kB
          Simon Endele

          Issue Links

            Activity

              People

              • Assignee:
                jbernste Joel Bernstein
                Reporter:
                simon.endele Simon Endele
              • Votes:
                1 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated: