Solr
  1. Solr
  2. SOLR-6754

ZkController.publish doesn't use the updateLastState parameter

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 4.10.2
    • Fix Version/s: 5.0, 6.0
    • Component/s: SolrCloud
    • Labels:
      None

      Description

      One of ZkController's overloaded publish method has the following:

      public void publish(final CoreDescriptor cd, final String state, boolean updateLastState) throws KeeperException, InterruptedException {
          publish(cd, state, true, false);
        }
      

      Regardless of the updateLastState argument, the method calls publish with updateLastState set to true.

      1. SOLR-6754.patch
        0.6 kB
        Shalin Shekhar Mangar

        Activity

        Hide
        Shalin Shekhar Mangar added a comment -

        Trivial patch to use the method argument is attached.

        Show
        Shalin Shekhar Mangar added a comment - Trivial patch to use the method argument is attached.
        Hide
        ASF subversion and git services added a comment -

        Commit 1641354 from shalin@apache.org in branch 'dev/trunk'
        [ https://svn.apache.org/r1641354 ]

        SOLR-6754: ZkController.publish doesn't use the updateLastState parameter

        Show
        ASF subversion and git services added a comment - Commit 1641354 from shalin@apache.org in branch 'dev/trunk' [ https://svn.apache.org/r1641354 ] SOLR-6754 : ZkController.publish doesn't use the updateLastState parameter
        Hide
        ASF subversion and git services added a comment -

        Commit 1641355 from shalin@apache.org in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1641355 ]

        SOLR-6754: ZkController.publish doesn't use the updateLastState parameter

        Show
        ASF subversion and git services added a comment - Commit 1641355 from shalin@apache.org in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1641355 ] SOLR-6754 : ZkController.publish doesn't use the updateLastState parameter
        Hide
        Anshum Gupta added a comment -

        Bulk close after 5.0 release.

        Show
        Anshum Gupta added a comment - Bulk close after 5.0 release.

          People

          • Assignee:
            Shalin Shekhar Mangar
            Reporter:
            Shalin Shekhar Mangar
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development