Solr
  1. Solr
  2. SOLR-6751

Analysis errors in DirectUpdateHandler2 throw ServerError exceptions

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.0
    • Component/s: None
    • Labels:
      None

      Description

      If you try and add a document with a docvalues field over 32k in length, lucene will throw an IllegalArgumentException. DirectUpdateHandler2.addDoc() catches this, but then re-throws as a SolrException with a 500 error code, so any clients trying to distinguish between bad data errors and server status errors will do the wrong thing.

      1. SOLR-6751.patch
        0.8 kB
        Alan Woodward

        Activity

        Hide
        Alan Woodward added a comment -

        Trivial patch, changing it to throw ErrorCode.BAD_REQUEST rather than ErrorCode.SERVER_ERROR

        Show
        Alan Woodward added a comment - Trivial patch, changing it to throw ErrorCode.BAD_REQUEST rather than ErrorCode.SERVER_ERROR
        Hide
        ASF subversion and git services added a comment -

        Commit 1641586 from Alan Woodward in branch 'dev/trunk'
        [ https://svn.apache.org/r1641586 ]

        SOLR-6751: Analysis errors should return BAD_REQUEST, not SERVER_ERROR

        Show
        ASF subversion and git services added a comment - Commit 1641586 from Alan Woodward in branch 'dev/trunk' [ https://svn.apache.org/r1641586 ] SOLR-6751 : Analysis errors should return BAD_REQUEST, not SERVER_ERROR
        Hide
        ASF subversion and git services added a comment -

        Commit 1641587 from Alan Woodward in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1641587 ]

        SOLR-6751: Analysis errors should return BAD_REQUEST, not SERVER_ERROR

        Show
        ASF subversion and git services added a comment - Commit 1641587 from Alan Woodward in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1641587 ] SOLR-6751 : Analysis errors should return BAD_REQUEST, not SERVER_ERROR
        Hide
        Anshum Gupta added a comment -

        Bulk close after 5.0 release.

        Show
        Anshum Gupta added a comment - Bulk close after 5.0 release.

          People

          • Assignee:
            Alan Woodward
            Reporter:
            Alan Woodward
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development