Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-6735

CloneFieldUpdateProcessorFactory should be null safe

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.0, 6.0
    • Component/s: None
    • Labels:
      None

      Description

      If a source field value is null the CloneFieldUpdateProcessor throws a null pointer exception.

      1. SOLR-6735.patch
        3 kB
        Steve Davids

        Activity

        Hide
        sdavids Steve Davids added a comment -

        Attached a trivial patch.

        Show
        sdavids Steve Davids added a comment - Attached a trivial patch.
        Hide
        sdavids Steve Davids added a comment -

        Anyone willing to commit this? With the attached patch any null value is ignored, an alternative approach is to preserve the null by adding it to the destination field. Regardless the approach, it should be null safe.

        Show
        sdavids Steve Davids added a comment - Anyone willing to commit this? With the attached patch any null value is ignored, an alternative approach is to preserve the null by adding it to the destination field. Regardless the approach, it should be null safe.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 1649323 from Erik Hatcher in branch 'dev/trunk'
        [ https://svn.apache.org/r1649323 ]

        SOLR-6735: Make CloneFieldUpdateProcessorFactory null safe

        Show
        jira-bot ASF subversion and git services added a comment - Commit 1649323 from Erik Hatcher in branch 'dev/trunk' [ https://svn.apache.org/r1649323 ] SOLR-6735 : Make CloneFieldUpdateProcessorFactory null safe
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 1649324 from Erik Hatcher in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1649324 ]

        SOLR-6735: Make CloneFieldUpdateProcessorFactory null safe (merged with CHANGES.txt manual edits from trunk r1649323)

        Show
        jira-bot ASF subversion and git services added a comment - Commit 1649324 from Erik Hatcher in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1649324 ] SOLR-6735 : Make CloneFieldUpdateProcessorFactory null safe (merged with CHANGES.txt manual edits from trunk r1649323)
        Hide
        ehatcher Erik Hatcher added a comment -

        committed. Thanks Steve!

        Show
        ehatcher Erik Hatcher added a comment - committed. Thanks Steve!
        Hide
        anshumg Anshum Gupta added a comment -

        Bulk close after 5.0 release.

        Show
        anshumg Anshum Gupta added a comment - Bulk close after 5.0 release.

          People

          • Assignee:
            ehatcher Erik Hatcher
            Reporter:
            sdavids Steve Davids
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development