Solr
  1. Solr
  2. SOLR-6715

ZkSolrResourceLoader constructors accept a parameter called "collection" but it should be "configName"

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.0, 6.0
    • Component/s: None
    • Labels:
      None

      Description

      public ZkSolrResourceLoader(String instanceDir, String collection,
            ZkController zooKeeperController);
      public ZkSolrResourceLoader(String instanceDir, String collection, ClassLoader parent,
            Properties coreProperties, ZkController zooKeeperController);
      

      The CloudConfigSetService created ZkSolrResourceLoader using the configName (which is correct).

      We should renamed the param in ZkSolrResourceLoader to be configSetName and also rename the "collectionZkPath" member to be "configSetZkPath"

      1. SOLR-6715.patch
        14 kB
        Shalin Shekhar Mangar

        Activity

        Hide
        Shalin Shekhar Mangar added a comment -

        Patch which renames collectionZkPath to configSetZkPath everywhere.

        Show
        Shalin Shekhar Mangar added a comment - Patch which renames collectionZkPath to configSetZkPath everywhere.
        Hide
        ASF subversion and git services added a comment -

        Commit 1637296 from shalin@apache.org in branch 'dev/trunk'
        [ https://svn.apache.org/r1637296 ]

        SOLR-6715: ZkSolrResourceLoader constructors accept a parameter called 'collection' but it should be 'configName'

        Show
        ASF subversion and git services added a comment - Commit 1637296 from shalin@apache.org in branch 'dev/trunk' [ https://svn.apache.org/r1637296 ] SOLR-6715 : ZkSolrResourceLoader constructors accept a parameter called 'collection' but it should be 'configName'
        Hide
        ASF subversion and git services added a comment -

        Commit 1637299 from shalin@apache.org in branch 'dev/trunk'
        [ https://svn.apache.org/r1637299 ]

        SOLR-6715: Fix javadoc warning

        Show
        ASF subversion and git services added a comment - Commit 1637299 from shalin@apache.org in branch 'dev/trunk' [ https://svn.apache.org/r1637299 ] SOLR-6715 : Fix javadoc warning
        Hide
        ASF subversion and git services added a comment -

        Commit 1641420 from Noble Paul in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1641420 ]

        SOLR-6533 , SOLR-6715 , SOLR-6654 Backporting all the changes from trunk

        Show
        ASF subversion and git services added a comment - Commit 1641420 from Noble Paul in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1641420 ] SOLR-6533 , SOLR-6715 , SOLR-6654 Backporting all the changes from trunk
        Hide
        ASF subversion and git services added a comment -

        Commit 1652355 from Anshum Gupta in branch 'dev/trunk'
        [ https://svn.apache.org/r1652355 ]

        SOLR-6715: Removing duplicate CHANGES.txt entry

        Show
        ASF subversion and git services added a comment - Commit 1652355 from Anshum Gupta in branch 'dev/trunk' [ https://svn.apache.org/r1652355 ] SOLR-6715 : Removing duplicate CHANGES.txt entry
        Hide
        ASF subversion and git services added a comment -

        Commit 1652357 from Anshum Gupta in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1652357 ]

        SOLR-6715: Removing duplicate CHANGES.txt entry (merge from trunk)

        Show
        ASF subversion and git services added a comment - Commit 1652357 from Anshum Gupta in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1652357 ] SOLR-6715 : Removing duplicate CHANGES.txt entry (merge from trunk)
        Hide
        ASF subversion and git services added a comment -

        Commit 1652358 from Anshum Gupta in branch 'dev/branches/lucene_solr_5_0'
        [ https://svn.apache.org/r1652358 ]

        SOLR-6715: Removing duplicate CHANGES.txt entry (merge from branch_5x)

        Show
        ASF subversion and git services added a comment - Commit 1652358 from Anshum Gupta in branch 'dev/branches/lucene_solr_5_0' [ https://svn.apache.org/r1652358 ] SOLR-6715 : Removing duplicate CHANGES.txt entry (merge from branch_5x)
        Hide
        Anshum Gupta added a comment -

        Bulk close after 5.0 release.

        Show
        Anshum Gupta added a comment - Bulk close after 5.0 release.

          People

          • Assignee:
            Shalin Shekhar Mangar
            Reporter:
            Shalin Shekhar Mangar
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development