Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-6715

ZkSolrResourceLoader constructors accept a parameter called "collection" but it should be "configName"

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Trivial
    • Resolution: Fixed
    • None
    • 5.0, 6.0
    • None
    • None

    Description

      public ZkSolrResourceLoader(String instanceDir, String collection,
            ZkController zooKeeperController);
      public ZkSolrResourceLoader(String instanceDir, String collection, ClassLoader parent,
            Properties coreProperties, ZkController zooKeeperController);
      

      The CloudConfigSetService created ZkSolrResourceLoader using the configName (which is correct).

      We should renamed the param in ZkSolrResourceLoader to be configSetName and also rename the "collectionZkPath" member to be "configSetZkPath"

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            shalin Shalin Shekhar Mangar
            shalin Shalin Shekhar Mangar
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment