Solr
  1. Solr
  2. SOLR-6698

Solr is not consistent wrt ZkCredentialsProvider / ZkCredentialProvider

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.0, 6.0
    • Component/s: SolrCloud
    • Labels:
      None

      Description

      Solr uses ZkCredentialsProvider / ZkCredentialProvider in inconsistent ways.

      For example, in the configs it's referred to as zkCredentialProvider
      https://github.com/apache/lucene-solr/blob/6dd0103c8130e6207151fa5c2f9ccfcfe9500c59/solr/core/src/java/org/apache/solr/core/ConfigSolrXml.java#L168

      but the cloud scripts show it as zkCredentialsProvider (wrong):
      https://github.com/apache/lucene-solr/blob/6dd0103c8130e6207151fa5c2f9ccfcfe9500c59/solr/cloud-dev/solrcloud-start.sh#L7

      The implementations refer to ZkCredentialsProvider, i.e.:
      https://github.com/apache/lucene-solr/blob/6dd0103c8130e6207151fa5c2f9ccfcfe9500c59/solr/solrj/src/java/org/apache/solr/common/cloud/ZkCredentialsProvider.java

      it would be good to be consistent here. I don't have a preference for which name to use. Unless we want to put in some code to handle old versions, it seems like we need to break compatibility (i.e. either rename the config names or the names of the implementing classes).

      1. SOLR-6698.patch
        4 kB
        Gregory Chanan

        Activity

        Hide
        Mark Miller added a comment -

        +1. I think this is new enough and likely with little enough use that we should mention it in the top upgrade level of changes, but simply fix it. I really should have marked the API's as experimental for a release or two, but we are generally fairly lenient on java API backcompat currently anyway. As long as we have a good fail message, I think it's fine.

        Show
        Mark Miller added a comment - +1. I think this is new enough and likely with little enough use that we should mention it in the top upgrade level of changes, but simply fix it. I really should have marked the API's as experimental for a release or two, but we are generally fairly lenient on java API backcompat currently anyway. As long as we have a good fail message, I think it's fine.
        Hide
        Gregory Chanan added a comment -

        Which way would you go, Mark Miller? ZkCredentialProvider or ZkCredentialsProvider?

        Show
        Gregory Chanan added a comment - Which way would you go, Mark Miller ? ZkCredentialProvider or ZkCredentialsProvider?
        Hide
        Gregory Chanan added a comment -

        Here's a patch that uses ZkCredentialsProvider and doesn't attempt backwards compatibility.

        Show
        Gregory Chanan added a comment - Here's a patch that uses ZkCredentialsProvider and doesn't attempt backwards compatibility.
        Hide
        Mark Miller added a comment -

        +1 - remember to call it out in the CHANGES upgrade section when you add the CHANGES entry.

        Show
        Mark Miller added a comment - +1 - remember to call it out in the CHANGES upgrade section when you add the CHANGES entry.
        Hide
        ASF subversion and git services added a comment -

        Commit 1637015 from gchanan@apache.org in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1637015 ]

        SOLR-6698: Solr is not consistent wrt ZkCredentialsProvider / ZkCredentialProvider

        Show
        ASF subversion and git services added a comment - Commit 1637015 from gchanan@apache.org in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1637015 ] SOLR-6698 : Solr is not consistent wrt ZkCredentialsProvider / ZkCredentialProvider
        Hide
        ASF subversion and git services added a comment -

        Commit 1637016 from gchanan@apache.org in branch 'dev/trunk'
        [ https://svn.apache.org/r1637016 ]

        SOLR-6698: Solr is not consistent wrt ZkCredentialsProvider / ZkCredentialProvider

        Show
        ASF subversion and git services added a comment - Commit 1637016 from gchanan@apache.org in branch 'dev/trunk' [ https://svn.apache.org/r1637016 ] SOLR-6698 : Solr is not consistent wrt ZkCredentialsProvider / ZkCredentialProvider
        Hide
        Gregory Chanan added a comment -

        Thanks for the review Mark, committed to 5.0 and trunk.

        Show
        Gregory Chanan added a comment - Thanks for the review Mark, committed to 5.0 and trunk.
        Hide
        Anshum Gupta added a comment -

        Bulk close after 5.0 release.

        Show
        Anshum Gupta added a comment - Bulk close after 5.0 release.

          People

          • Assignee:
            Gregory Chanan
            Reporter:
            Gregory Chanan
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development