[SOLR-6698] Solr is not consistent wrt ZkCredentialsProvider / ZkCredentialProvider

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 5.0, 6.0
• Component/s: SolrCloud
• Assignee: Gregory Chanan
• Reporter: Gregory Chanan
• Created: 03/Nov/14 23:27
• Updated: 09/May/16 18:50
• Resolved: 06/Nov/14 00:26

Description

Solr uses ZkCredentialsProvider / ZkCredentialProvider in inconsistent ways.

For example, in the configs it's referred to as zkCredentialProvider
https://github.com/apache/lucene-solr/blob/6dd0103c8130e6207151fa5c2f9ccfcfe9500c59/solr/core/src/java/org/apache/solr/core/ConfigSolrXml.java#L168

but the cloud scripts show it as zkCredentialsProvider (wrong):
https://github.com/apache/lucene-solr/blob/6dd0103c8130e6207151fa5c2f9ccfcfe9500c59/solr/cloud-dev/solrcloud-start.sh#L7

The implementations refer to ZkCredentialsProvider, i.e.:
https://github.com/apache/lucene-solr/blob/6dd0103c8130e6207151fa5c2f9ccfcfe9500c59/solr/solrj/src/java/org/apache/solr/common/cloud/ZkCredentialsProvider.java

it would be good to be consistent here. I don't have a preference for which name to use. Unless we want to put in some code to handle old versions, it seems like we need to break compatibility (i.e. either rename the config names or the names of the implementing classes).