Solr
  1. Solr
  2. SOLR-6696

bin/solr start script should not enable autoSoftCommit by default

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 4.10.2
    • Fix Version/s: 4.10.3, 5.0, 6.0
    • Component/s: scripts and tools
    • Labels:
      None

      Description

      Starting Solr with bin/solr start script automatically sets this param -Dsolr.autoSoftCommit.maxTime=3000 without this being documented in help.

      It is really confusing, because when looking at solrconfig.xml, you expect the default to be disabled (-1).

      I think most of the JAVA OPTIONs being set in the script are sane, but I disagree with this one. The defaults for this script should be same as the defaults in the config. The user can always specify this as -a "-Dsolr.autoSoftCommit.maxTime=NN".

      1. SOLR-6696.patch
        2 kB
        Jan Høydahl
      2. SOLR-6696.patch
        0.5 kB
        Jan Høydahl

        Activity

        Hide
        Jan Høydahl added a comment -

        Patch

        Show
        Jan Høydahl added a comment - Patch
        Hide
        Jan Høydahl added a comment -

        Also for solr.cmd

        Show
        Jan Høydahl added a comment - Also for solr.cmd
        Hide
        ASF subversion and git services added a comment -

        Commit 1636760 from janhoy@apache.org in branch 'dev/trunk'
        [ https://svn.apache.org/r1636760 ]

        SOLR-6696: bin/solr start script should not enable autoSoftCommit by default

        Show
        ASF subversion and git services added a comment - Commit 1636760 from janhoy@apache.org in branch 'dev/trunk' [ https://svn.apache.org/r1636760 ] SOLR-6696 : bin/solr start script should not enable autoSoftCommit by default
        Hide
        ASF subversion and git services added a comment -

        Commit 1636761 from janhoy@apache.org in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1636761 ]

        SOLR-6696: bin/solr start script should not enable autoSoftCommit by default (merge from trunk)

        Show
        ASF subversion and git services added a comment - Commit 1636761 from janhoy@apache.org in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1636761 ] SOLR-6696 : bin/solr start script should not enable autoSoftCommit by default (merge from trunk)
        Hide
        ASF subversion and git services added a comment -

        Commit 1636763 from janhoy@apache.org in branch 'dev/branches/lucene_solr_4_10'
        [ https://svn.apache.org/r1636763 ]

        SOLR-6696: bin/solr start script should not enable autoSoftCommit by default (merge)

        Show
        ASF subversion and git services added a comment - Commit 1636763 from janhoy@apache.org in branch 'dev/branches/lucene_solr_4_10' [ https://svn.apache.org/r1636763 ] SOLR-6696 : bin/solr start script should not enable autoSoftCommit by default (merge)
        Hide
        Jan Høydahl added a comment -

        Committed. Assuming there will be a 4.10.3 some day, changes entries went into 4.10.3 section for all branches. If not, we can fix CHANGES later.

        Show
        Jan Høydahl added a comment - Committed. Assuming there will be a 4.10.3 some day, changes entries went into 4.10.3 section for all branches. If not, we can fix CHANGES later.
        Hide
        Anshum Gupta added a comment -

        Bulk close after 5.0 release.

        Show
        Anshum Gupta added a comment - Bulk close after 5.0 release.

          People

          • Assignee:
            Jan Høydahl
            Reporter:
            Jan Høydahl
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development