[SOLR-6693] Start script for windows fails with 32bit JRE

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 4.10.2
• Fix Version/s: 4.10.4, 5.0, 6.0
• Component/s: scripts and tools
• Labels: bin\solr.cmd

Environment

WINDOWS 8.1

• Assignee: Steven Rowe
• Reporter: Jan Høydahl
• Created: 03/Nov/14 20:21
• Updated: 09/May/16 18:49
• Resolved: 26/Feb/15 23:06

Description

Reproduce:

1. Install JRE8 from www.java.com (typically C:\Program Files (x86)\Java\jre1.8.0_25)
2. Run the command bin\solr start -V

The result is:
\Java\jre1.8.0_25\bin\java was unexpected at this time.

Reason
This comes from bad quoting of the %SOLR% variable. I think it's because of the parenthesis that it freaks out. I think the same would apply for a 32-bit JDK because of the (x86) in the path, but I have not tested.

Tip: You can remove the line @ECHO OFF at the top to see exactly which is the offending line

Solution
Quoting the lines where %JAVA% is printed, e.g. instead of

  @echo Using Java: %JAVA%

then use

  @echo "Using Java: %JAVA%"

This is needed several places.

Issue Links

• relates to: SOLR-7047 solr.cmd fails if Solr installation path contains parenthesis