Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-666

Expose warmup time in statistics for SolrIndexSearcher and LRUCache

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.3
    • Fix Version/s: 1.3
    • Component/s: Admin UI, search
    • Labels:
      None

      Description

      Expose time taken for auto warming in getStatistics method for both SolrIndexSearcher (total warmup time) as well as in LRUCache (individual warmup time) to aid monitoring.

      1. SOLR-666.patch
        2 kB
        Shalin Shekhar Mangar

        Activity

        Hide
        shalinmangar Shalin Shekhar Mangar added a comment -

        Committed revision 680916.

        Show
        shalinmangar Shalin Shekhar Mangar added a comment - Committed revision 680916.
        Hide
        shalinmangar Shalin Shekhar Mangar added a comment -

        Yes, that is true for SolrIndexSearcher but we don't have it individually for the two caches. Secondly, JMX monitoring and graphing tools usually can't do arithmetic out of the box.

        Show
        shalinmangar Shalin Shekhar Mangar added a comment - Yes, that is true for SolrIndexSearcher but we don't have it individually for the two caches. Secondly, JMX monitoring and graphing tools usually can't do arithmetic out of the box.
        Hide
        yseeley@gmail.com Yonik Seeley added a comment -

        Isn't this redundant? We already have the time it was created, and the time it was registered. Everything in between is warming time.

        Show
        yseeley@gmail.com Yonik Seeley added a comment - Isn't this redundant? We already have the time it was created, and the time it was registered. Everything in between is warming time.
        Hide
        shalinmangar Shalin Shekhar Mangar added a comment -

        Adds warmupTime instance variables to both SolrIndexSearcher and LRUCache. The time is calculated in the respective warm methods. The getStatistics methods add this value to the statistics NamedList.

        I will commit this shortly.

        Show
        shalinmangar Shalin Shekhar Mangar added a comment - Adds warmupTime instance variables to both SolrIndexSearcher and LRUCache. The time is calculated in the respective warm methods. The getStatistics methods add this value to the statistics NamedList. I will commit this shortly.

          People

          • Assignee:
            shalinmangar Shalin Shekhar Mangar
            Reporter:
            shalinmangar Shalin Shekhar Mangar
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development