Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-6660 Improve the usability for the new Suggester
  3. SOLR-6657

DocumentDictionaryFactory requires weightField to be mandatory, but it shouldn't

    Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 4.8, 4.8.1, 4.9, 4.9.1, 4.10, 4.10.1
    • Fix Version/s: 5.1, 6.0
    • Component/s: None
    • Labels:

      Description

      DocumentDictionaryFactory requires weightField to be mandatory, but it doesn't need to as DocumentDictionary allows it to be null

      So one has to define the weight field in the solrconfig.xml even if their data doesn't contain any weights. We shouldn't make the weightField mandatory in DocumentDictionaryFactory

        Activity

        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 1663527 from Erick Erickson in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1663527 ]

        SOLR-6657: DocumentDictionaryFactory requires weightField to be mandatory, but it shouldn't

        Show
        jira-bot ASF subversion and git services added a comment - Commit 1663527 from Erick Erickson in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1663527 ] SOLR-6657 : DocumentDictionaryFactory requires weightField to be mandatory, but it shouldn't
        Hide
        erickerickson Erick Erickson added a comment -

        this would be super-easy to backport, but unless we fix the other problems with suggester there's no point.

        Show
        erickerickson Erick Erickson added a comment - this would be super-easy to backport, but unless we fix the other problems with suggester there's no point.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 1663525 from Erick Erickson in branch 'dev/trunk'
        [ https://svn.apache.org/r1663525 ]

        SOLR-6657: DocumentDictionaryFactory requires weightField to be mandatory, but it shouldn't

        Show
        jira-bot ASF subversion and git services added a comment - Commit 1663525 from Erick Erickson in branch 'dev/trunk' [ https://svn.apache.org/r1663525 ] SOLR-6657 : DocumentDictionaryFactory requires weightField to be mandatory, but it shouldn't
        Hide
        erickerickson Erick Erickson added a comment -

        This is super-annoying since when this error is reported, one thinks that it's important to have something here that makes sense. Looks like a one-line change anyway.

        Show
        erickerickson Erick Erickson added a comment - This is super-annoying since when this error is reported, one thinks that it's important to have something here that makes sense. Looks like a one-line change anyway.

          People

          • Assignee:
            erickerickson Erick Erickson
            Reporter:
            varunthacker Varun Thacker
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development