[SOLR-6656] FreeTextLookupFactory QUERY_ANALYZER constants value should be "suggestAnalyzerFieldType"

• Type: Sub-task
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: 4.8, 4.8.1, 4.9, 4.9.1, 4.10, 4.10.1
• Fix Version/s: 5.0, 6.0
• Labels: suggester
• Assignee: Unassigned
• Reporter: Varun Thacker
• Created: 27/Oct/14 08:10
• Updated: 09/May/16 18:59

Description

In our lookup factories, the value for the constant QUERY_ANALYZER is :

AnalyzingLookupFactory and AnalyzingInfixLookupFactory = "suggestAnalyzerFieldType"

FuzzyLookupFactory refers to AnalyzingLookupFactory.QUERY_ANALYZER

While FreeTextLookupFactory uses "suggestFreeTextAnalyzerFieldType"

I think we should keep the constant QUERY_ANALYZER in LookupFactory and let all the factories that use them reference it.

Patch would be very simple but should we deprecate in branch_5x and remove it in trunk , or remove it in both branches?